Changeset 47931

Timestamp:

06/09/2020 11:25:53 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Site Health: Avoid a PHP notice in WP_Site_Health::wp_cron_scheduled_check() if async test response does not contain the expected result.

Additionally, avoid a PHP notice in ::get_test_php_version() if the minimum recommended version of PHP could not be determined.

Props schlessera, oakesjosh.
Merges [47628] to the 5.4 branch.
Fixes #49943.

Location:

branches/5.4

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/class-wp-site-health.php (modified) (2 diffs)

branches/5.4/src/wp-admin/includes/class-wp-site-health.php

@@ -720 +720 @@
                     /* translators: %s: The minimum recommended PHP version. */
                     __( 'PHP is the programming language used to build and maintain WordPress. Newer versions of PHP are faster and more secure, so staying up to date will help your site’s overall performance and security. The minimum recommended version of PHP is %s.' ),
-                    $response['recommended_version']
+                    $response ? $response['recommended_version'] : ''
                 )
             ),
@@ -2290 +2290 @@
 
                 if ( ! is_wp_error( $result_fetch ) ) {
-                    $results[] = json_decode( wp_remote_retrieve_body( $result_fetch ) );
+                    $result = json_decode( wp_remote_retrieve_body( $result_fetch ), true );
+                } else {
+                    $result = false;
+                }
+
+                if ( is_array( $result ) ) {
+                    $results[] = $result;
                 } else {
                     $results[] = array(