Changeset 47963 for branches/5.1/tests/phpunit/tests/oembed/filterResult.php

Timestamp:

06/10/2020 06:18:25 PM (5 years ago)

Author:

desrosj

Message:

General: Backport several commits for release.

• Embeds: Ensure that the title attribute is set correctly on embeds.
• Editor: Prevent HTML decoding on by setting the proper editor context.
• Formatting: Ensure that wp_validate_redirect() sanitizes a wider variety of characters.
• Themes: Ensure a broken theme name is returned properly.
• Administration: Add a new filter to extend set-screen-option.

Merges [47947-47951] to the 5.1 branch.
Props xknown, sstoqnov, vortfu, SergeyBiryukov, whyisjake.

Location:

branches/5.1

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/oembed/filterResult.php (modified) (1 diff)

branches/5.1/tests/phpunit/tests/oembed/filterResult.php

@@ -103 +103 @@
         $this->assertEquals( '<blockquote class="wp-embedded-content"></blockquote><iframe class="wp-embedded-content" sandbox="allow-scripts" security="restricted"></iframe>', $actual );
     }
+
+    public function _data_oembed_test_strings() {
+        return array(
+            array(
+                '<blockquote></blockquote><iframe title=""></iframe>',
+                '<blockquote class="wp-embedded-content"></blockquote><iframe class="wp-embedded-content" sandbox="allow-scripts" security="restricted" style="position: absolute; clip: rect(1px, 1px, 1px, 1px);" title="Hola"></iframe>',
+            ),
+            array(
+                '<blockquote class="foo" id="bar"><strong><a href="" target=""></a></strong></blockquote><iframe width=123></iframe>',
+                '<blockquote class="wp-embedded-content"><a href=""></a></blockquote><iframe class="wp-embedded-content" sandbox="allow-scripts" security="restricted" style="position: absolute; clip: rect(1px, 1px, 1px, 1px);" title="Hola" width="123"></iframe>',
+            ),
+            array(
+                '<blockquote><iframe width="100"></iframe></blockquote><iframe stitle="aaaa"></iframe>',
+                '<blockquote class="wp-embedded-content"><iframe class="wp-embedded-content" sandbox="allow-scripts" security="restricted" style="position: absolute; clip: rect(1px, 1px, 1px, 1px);" title="Hola" width="100"></iframe></blockquote><iframe class="wp-embedded-content" sandbox="allow-scripts" security="restricted" style="position: absolute; clip: rect(1px, 1px, 1px, 1px);" title="Hola"></iframe>',
+            ),
+            array(
+                "<blockquote><iframe title=' width=\"'></iframe></blockquote><iframe title='' height=' title=' width=\"'' heigt='123'\"></iframe>",
+                '<blockquote class="wp-embedded-content"><iframe class="wp-embedded-content" sandbox="allow-scripts" security="restricted" style="position: absolute; clip: rect(1px, 1px, 1px, 1px);" title=" width=&quot;"></iframe></blockquote><iframe class="wp-embedded-content" sandbox="allow-scripts" security="restricted" style="position: absolute; clip: rect(1px, 1px, 1px, 1px);" title=" width=&quot;" height=\' title=\' width="\'\' heigt=\'123\'"></iframe>',
+            ),
+        );
+    }
+
+    /**
+     * @dataProvider _data_oembed_test_strings
+     */
+    public function test_wp_filter_pre_oembed_custom_result( $html, $expected ) {
+        $data   = (object) array(
+            'type'  => 'rich',
+            'title' => 'Hola',
+            'html'  => $html,
+        );
+        $actual = _wp_oembed_get_object()->data2html( $data, 'https://untrusted.localhost' );
+        $this->assertEquals( $expected, $actual );
+    }
 }