Changeset 4798

Timestamp:

01/25/2007 12:12:08 AM (20 years ago)

Author:

markjaquith

Message:

Cache the non-existence of options to prevent redundant queries. props davidhouse. fixes #2268

File:

• trunk/wp-includes/functions.php (modified) (3 diffs)

trunk/wp-includes/functions.php

@@ -204 +204 @@
         global $wpdb;
 
+        // prevent non-existent options from triggering multiple queries
+        if ( true === wp_cache_get($setting, 'notoptions') )
+                return false;
+
         $value = wp_cache_get($setting, 'options');
 
@@ -216 +220 @@
                         $value = $row->option_value;
                         wp_cache_set($setting, $value, 'options');
-                } else {
+                } else { // option does not exist, so we must cache its non-existence
+                        wp_cache_set($setting, true, 'notoptions');
                         return false;
                 }
@@ -274 +279 @@
                 return true;
         }
+
+        if ( true === wp_cache_get($option_name, 'notoptions') )
+                wp_cache_delete($option_name, 'notoptions');
 
         $_newvalue = $newvalue;