Changeset 48037

Timestamp:

06/13/2020 02:24:30 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Themes: Ensure the theme slug is set before checking if the theme is installed or active.

This fixes an issue with every installed theme being marked as active on Themes screen.

The slug is set on Add Themes screen, but not on Themes.

Follow-up to [47924].

Props BackuPs, mukesh27, SergeyBiryukov.
Fixes #50381. See #50334.

File:

• trunk/src/js/_enqueues/wp/theme.js (modified) (1 diff)

trunk/src/js/_enqueues/wp/theme.js

@@ -29 +29 @@
         var description;
 
-        // If the theme is already installed, set an attribute.
-        if ( _.indexOf( themes.data.installedThemes, this.get( 'slug' ) ) !== -1 ) {
-            this.set({ installed: true });
-        }
-
-        // If the theme is active, set an attribute.
-        if ( themes.data.activeTheme === this.get( 'slug' ) ) {
-            this.set({ active: true });
+        if ( this.get( 'slug' ) ) {
+            // If the theme is already installed, set an attribute.
+            if ( _.indexOf( themes.data.installedThemes, this.get( 'slug' ) ) !== -1 ) {
+                this.set({ installed: true });
+            }
+
+            // If the theme is active, set an attribute.
+            if ( themes.data.activeTheme === this.get( 'slug' ) ) {
+                this.set({ active: true });
+            }
         }