Changeset 48050 for trunk/src/wp-admin/includes/class-wp-list-table.php

Timestamp:

06/15/2020 11:04:27 PM (5 years ago)

Author:

whyisjake

Message:

Comments: Don't display edit links to trashed post comments.

If a post is in the trash, the comments bubble won't link to the comments list.

Fixes: #37826.
Props: swissspidy, helen, FolioVision, DrewAPicture, stevenlinx, donmhico, birgire, garrett-eclipse, andraganescu, johnbillion.

File:

• trunk/src/wp-admin/includes/class-wp-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -683 +683 @@
         );
 
-        // No comments at all.
         if ( ! $approved_comments && ! $pending_comments ) {
+            // No comments at all.
             printf(
                 '<span aria-hidden="true">&#8212;</span><span class="screen-reader-text">%s</span>',
                 __( 'No comments' )
             );
-            // Approved comments have different display depending on some conditions.
+        } elseif ( $approved_comments && 'trash' === get_post_status( $post_id ) ) {
+            // Don't link the comment bubble for a trashed post.
+            printf(
+                '<span class="post-com-count post-com-count-approved"><span class="comment-count-approved" aria-hidden="true">%s</span><span class="screen-reader-text">%s</span></span>',
+                $approved_comments_number,
+                $pending_comments ? $approved_phrase : $approved_only_phrase
+            );
         } elseif ( $approved_comments ) {
+            // Link the comment bubble to approved comments.
             printf(
                 '<a href="%s" class="post-com-count post-com-count-approved"><span class="comment-count-approved" aria-hidden="true">%s</span><span class="screen-reader-text">%s</span></a>',
@@ -706 +713 @@
             );
         } else {
+            // Don't link the comment bubble when there are no approved comments.
             printf(
                 '<span class="post-com-count post-com-count-no-comments"><span class="comment-count comment-count-no-comments" aria-hidden="true">%s</span><span class="screen-reader-text">%s</span></span>',