Changeset 48055

Timestamp:

06/16/2020 06:28:57 AM (5 years ago)

Author:

whyisjake

Message:

Cache API: Add wp_cache_get_multiple() to core functions.

• update_object_term_cache
• update_meta_cache
• _get_non_cached_ids

See [47938].

Fixes #50352.

Props spacedmonkey, tillkruss, lukecavanagh.

Location:

trunk/src/wp-includes

Files:

• functions.php (modified) (1 diff)
• meta.php (modified) (1 diff)
• taxonomy.php (modified) (1 diff)

trunk/src/wp-includes/functions.php

@@ -6360 +6360 @@
  */
 function _get_non_cached_ids( $object_ids, $cache_key ) {
-    $clean = array();
-    foreach ( $object_ids as $id ) {
+    $clean        = array();
+    $cache_values = wp_cache_get_multiple( $object_ids, $cache_key );
+    foreach ( $cache_values as $id => $cache_value ) {
         $id = (int) $id;
-        if ( ! wp_cache_get( $id, $cache_key ) ) {
+        if ( ! $cache_value ) {
             $clean[] = $id;
         }

trunk/src/wp-includes/meta.php

@@ -927 +927 @@
     }
 
-    $cache_key = $meta_type . '_meta';
-    $ids       = array();
-    $cache     = array();
-    foreach ( $object_ids as $id ) {
-        $cached_object = wp_cache_get( $id, $cache_key );
+    $cache_key    = $meta_type . '_meta';
+    $ids          = array();
+    $cache        = array();
+    $cache_values = wp_cache_get_multiple( $object_ids, $cache_key );
+    foreach ( $cache_values as $id => $cached_object ) {
         if ( false === $cached_object ) {
             $ids[] = $id;

trunk/src/wp-includes/taxonomy.php

@@ -3411 +3411 @@
 
     $ids = array();
-    foreach ( (array) $object_ids as $id ) {
-        foreach ( $taxonomies as $taxonomy ) {
-            if ( false === wp_cache_get( $id, "{$taxonomy}_relationships" ) ) {
-                $ids[] = $id;
+    foreach ( $taxonomies as $taxonomy ) {
+        $cache_values = wp_cache_get_multiple( (array) $object_ids, "{$taxonomy}_relationships" );
+        foreach ( $cache_values as $key => $value ) {
+            if ( false === $value ) {
+                $ids[] = $key;
                 break;
             }