Changeset 48056

Timestamp:

06/16/2020 07:07:54 AM (5 years ago)

Author:

whyisjake

Message:

Administration: Remove wp-auth-check from the Heartbeat API.

As of [27153], wp-auth-check is returned on all heartbeats without the need for data from client-side. This also means that the timing and scheduling of this request data is ineffectual.

Fixes #50305.

Props dsixinetu, azaozz, whyisjake.

Location:

trunk/src

Files:

• js/_enqueues/lib/auth-check.js (modified) (4 diffs)
• wp-includes/script-loader.php (modified) (1 diff)

trunk/src/js/_enqueues/lib/auth-check.js

@@ -7 +7 @@
 /* global adminpage */
 (function($){
-    var wrap, next;
+    var wrap;
 
     /**
@@ -112 +112 @@
 
     /**
-     * Schedules when the next time the authentication check will be done.
-     *
-     * @since 3.6.0
-     * @private
-     */
-    function schedule() {
-        // In seconds, default 3 min.
-        var interval = parseInt( window.authcheckL10n.interval, 10 ) || 180;
-        next = ( new Date() ).getTime() + ( interval * 1000 );
-    }
-
-    /**
      * Binds to the Heartbeat Tick event.
      *
@@ -139 +127 @@
     $( document ).on( 'heartbeat-tick.wp-auth-check', function( e, data ) {
         if ( 'wp-auth-check' in data ) {
-            schedule();
             if ( ! data['wp-auth-check'] && wrap.hasClass('hidden') ) {
                 show();
@@ -146 +133 @@
             }
         }
-
-    /**
-     * Binds to the Heartbeat Send event.
-     *
-     * @ignore
-     *
-     * @since 3.6.0
-     *
-     * @param {Object} e The heartbeat-send event that has been triggered.
-     * @param {Object} data Response data.
-     */
-    }).on( 'heartbeat-send.wp-auth-check', function( e, data ) {
-        if ( ( new Date() ).getTime() > next ) {
-            data['wp-auth-check'] = true;
-        }
-
     }).ready( function() {
-        schedule();
 
         /**

trunk/src/wp-includes/script-loader.php

@@ -720 +720 @@
         array(
             'beforeunload' => __( 'Your session has expired. You can log in again from this page or go to the login page.' ),
-
-            /**
-             * Filters the authentication check interval.
-             *
-             * @since 3.6.0
-             *
-             * @param int $interval The interval in which to check a user's authentication.
-             *                      Default 3 minutes in seconds, or 180.
-             */
-            'interval'     => apply_filters( 'wp_auth_check_interval', 3 * MINUTE_IN_SECONDS ),
         )
     );