Changeset 48092

Timestamp:

06/19/2020 04:49:58 PM (6 years ago)

Author:

azaozz

Message:

Plugins and Themes Auto-Updates:

• Fix displaying of errors on the Themes screen.
• Correct the classes used for the error messages, and use notice-alt as notices are mostly shown on a white background.

Props afercia, azaozz.
Fixes #50405.

Location:

trunk/src

Files:

• js/_enqueues/wp/updates.js (modified) (3 diffs)
• wp-admin/includes/class-wp-ms-themes-list-table.php (modified) (1 diff)
• wp-admin/includes/class-wp-plugins-list-table.php (modified) (1 diff)
• wp-admin/themes.php (modified) (2 diffs)

trunk/src/js/_enqueues/wp/updates.js

@@ -2720 +2720 @@
 
             // Clear any previous errors.
-            $parent.find( '.notice.error' ).addClass( 'hidden' );
+            $parent.find( '.notice.notice-error' ).addClass( 'hidden' );
 
             // Show loading status.
@@ -2753 +2753 @@
                         }
 
-                        $parent.find( '.notice.error' ).removeClass( 'hidden' ).find( 'p' ).text( errorMessage );
+                        $parent.find( '.notice.notice-error' ).removeClass( 'hidden' ).find( 'p' ).text( errorMessage );
                         wp.a11y.speak( errorMessage, 'polite' );
                         return;
@@ -2809 +2809 @@
                 } )
                 .fail( function() {
-                    $parent.find( '.notice.error' )
+                    $parent.find( '.notice.notice-error' )
                         .removeClass( 'hidden' )
                         .find( 'p' )

trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

@@ -776 +776 @@
         echo apply_filters( 'theme_auto_update_setting_html', $html, $stylesheet, $theme );
 
-        echo '<div class="auto-updates-error inline notice error hidden"><p></p></div>';
+        echo '<div class="notice notice-error notice-alt inline hidden"><p></p></div>';
     }
 

trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

@@ -1097 +1097 @@
                     echo apply_filters( 'plugin_auto_update_setting_html', $html, $plugin_file, $plugin_data );
 
-                    echo '<div class="inline notice error hidden"><p></p></div>';
+                    echo '<div class="notice notice-error notice-alt inline hidden"><p></p></div>';
                     echo '</td>';
 

trunk/src/wp-admin/themes.php

@@ -560 +560 @@
 function wp_theme_auto_update_setting_template() {
     $template = '
-        <p class="theme-autoupdate">
+        <div class="theme-autoupdate">
             <# if ( data.autoupdate ) { #>
                 <a href="{{{ data.actions.autoupdate }}}" class="toggle-auto-update" data-slug="{{ data.id }}" data-wp-action="disable">
@@ -580 +580 @@
                 <br />' . wp_get_auto_update_message() . '</span>
             <# } #>
-            <span class="auto-updates-error hidden"><p></p></span>
-        </p>
+            <div class="notice notice-error notice-alt inline hidden"><p></p></div>
+        </div>
     ';