Changeset 48113 for trunk/tests/phpunit/tests/query/setupPostdata.php

Timestamp:

06/21/2020 10:28:52 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Posts, Post Types: Simplify test_setup_postdata_loop().

The important part here is calling the_content() after setting up post data for another post without updating global $post.

The foreach() loop is not necessary.

Follow-up to ​[UT1289].

See #47824, #24330.

File:

• trunk/tests/phpunit/tests/query/setupPostdata.php (modified) (1 diff)

trunk/tests/phpunit/tests/query/setupPostdata.php

@@ -399 +399 @@
      * @ticket 24330
      *
-     * setup_postdata( $a_post ) followed by the_content() in a loop that does not update
-     * global $post should use the content of $a_post rather then the global post.
-     */
-    function test_setup_postdata_loop() {
+     * setup_postdata( $a_post ) followed by the_content() without updating global $post
+     * should use the content of $a_post rather then the global post.
+     */
+    function test_setup_postdata_with_the_content() {
         $post_id                   = self::factory()->post->create( array( 'post_content' => 'global post' ) );
         $GLOBALS['post']           = get_post( $post_id );
         $GLOBALS['wp_query']->post = $GLOBALS['post'];
 
-        $ids = self::factory()->post->create_many( 5 );
-        foreach ( $ids as $id ) {
-            $page = get_post( $id );
-            if ( $page ) {
-                setup_postdata( $page );
-                $content = get_echo( 'the_content', array() );
-                $this->assertEquals( $post_id, $GLOBALS['post']->ID );
-                $this->assertNotEquals( '<p>global post</p>', strip_ws( $content ) );
-                wp_reset_postdata();
-            }
-        }
+        $a_post_id = self::factory()->post->create();
+        $a_post    = get_post( $a_post_id );
+
+        setup_postdata( $a_post );
+        $content = get_echo( 'the_content' );
+        $this->assertEquals( $post_id, $GLOBALS['post']->ID );
+        $this->assertNotEquals( '<p>global post</p>', strip_ws( $content ) );
+        wp_reset_postdata();
     }