Changeset 48118

Timestamp:

06/22/2020 12:20:20 PM (4 years ago)

Author:

gziolo

Message:

Editor: Remove default "layout" block attribute from WP_Block_Type::get_attributes

The merging behavior which assigns the layout attribute in WP_Block_Type gets removed.

Props aduth, TimothyBlynJacobs.
Fixes #50257.

Location:

trunk

Files:

• src/wp-includes/class-wp-block-type.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-block-renderer-controller.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-block-type.php

@@ -277 +277 @@
     public function get_attributes() {
         return is_array( $this->attributes ) ?
-            array_merge(
-                $this->attributes,
-                array(
-                    'layout' => array(
-                        'type' => 'string',
-                    ),
-                )
-            ) :
-            array(
-                'layout' => array(
-                    'type' => 'string',
-                ),
-            );
+            $this->attributes :
+            array();
     }
 }

trunk/tests/phpunit/tests/rest-api/rest-block-renderer-controller.php

@@ -426 +426 @@
 
     /**
-     * Check success response for getting item with layout attribute provided.
-     *
-     * @ticket 45098
-     */
-    public function test_get_item_with_layout() {
-        wp_set_current_user( self::$user_id );
-
-        $attributes = array(
-            'layout' => 'foo',
-        );
-
-        $request = new WP_REST_Request( 'GET', self::$rest_api_route . self::$block_name );
-        $request->set_param( 'context', 'edit' );
-        $request->set_param( 'attributes', $attributes );
-        $response = rest_get_server()->dispatch( $request );
-        $this->assertEquals( 200, $response->get_status() );
-    }
-
-    /**
      * Test getting item with post context.
      *