Make WordPress Core


Ignore:
Timestamp:
06/22/2020 05:24:34 PM (4 years ago)
Author:
desrosj
Message:

General: Remove “whitelist” and “blacklist” in favor of more clear and inclusive language.

“The WordPress open source community cares about diversity. We strive to maintain a welcoming environment where everyone can feel included.”

With this commit, all occurrences of “whitelist” and “blacklist” (with the single exception of the $new_whitelist_options global variable) are removed. A new ticket has been opened to explore renaming the $new_whitelist_options variable (#50434).

Changing to more specific names or rewording sentences containing these terms not only makes the code more inclusive, but also helps provide clarity. These terms are often ambiguous. What is being blocked or allowed is not always immediately clear. This can make it more difficult for non-native English speakers to read through the codebase.

Words matter. If one contributor feels more welcome because these terms are removed, this was worth the effort.

Props strangerstudios, jorbin, desrosj, joemcgill, timothyblynjacobs, ocean90, ayeshrajans, davidbaumwald, earnjam.
See #48900, #50434.
Fixes #50413.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/includes/factory/class-wp-unittest-factory-for-blog.php

    r47014 r48121  
    4141
    4242        if ( isset( $args['meta'] ) ) {
    43             // The `$site_data_whitelist` matches the one used in `wpmu_create_blog()`.
    44             $site_data_whitelist = array( 'public', 'archived', 'mature', 'spam', 'deleted', 'lang_id' );
     43            // The `$allowed_data_fields` matches the one used in `wpmu_create_blog()`.
     44            $allowed_data_fields = array( 'public', 'archived', 'mature', 'spam', 'deleted', 'lang_id' );
    4545
    4646            foreach ( $args['meta'] as $key => $value ) {
    47                 // Promote whitelisted keys to top-level arguments, add others to the options array.
    48                 if ( in_array( $key, $site_data_whitelist, true ) ) {
     47                // Promote allowed keys to top-level arguments, add others to the options array.
     48                if ( in_array( $key, $allowed_data_fields, true ) ) {
    4949                    $args[ $key ] = $value;
    5050                } else {
Note: See TracChangeset for help on using the changeset viewer.