Make WordPress Core


Ignore:
Timestamp:
06/22/2020 05:24:34 PM (4 years ago)
Author:
desrosj
Message:

General: Remove “whitelist” and “blacklist” in favor of more clear and inclusive language.

“The WordPress open source community cares about diversity. We strive to maintain a welcoming environment where everyone can feel included.”

With this commit, all occurrences of “whitelist” and “blacklist” (with the single exception of the $new_whitelist_options global variable) are removed. A new ticket has been opened to explore renaming the $new_whitelist_options variable (#50434).

Changing to more specific names or rewording sentences containing these terms not only makes the code more inclusive, but also helps provide clarity. These terms are often ambiguous. What is being blocked or allowed is not always immediately clear. This can make it more difficult for non-native English speakers to read through the codebase.

Words matter. If one contributor feels more welcome because these terms are removed, this was worth the effort.

Props strangerstudios, jorbin, desrosj, joemcgill, timothyblynjacobs, ocean90, ayeshrajans, davidbaumwald, earnjam.
See #48900, #50434.
Fixes #50413.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/media.php

    r47554 r48121  
    14741474
    14751475        foreach ( $image_meta['sizes'] as $name => $size ) {
    1476             // Whitelist the sizes that should be included so we pick up 'medium_large' in 4.4.
     1476            // Allow the sizes that should be included so we pick up 'medium_large' in 4.4.
    14771477            if ( in_array( $name, $intermediates, true ) ) {
    14781478                $expected .= $uploads_dir_url . $year_month . '/' . $size['file'] . ' ' . $size['width'] . 'w, ';
     
    15191519
    15201520        foreach ( $image_meta['sizes'] as $name => $size ) {
    1521             // Whitelist the sizes that should be included so we pick up 'medium_large' in 4.4.
     1521            // Allow the sizes that should be included so we pick up 'medium_large' in 4.4.
    15221522            if ( in_array( $name, $intermediates, true ) ) {
    15231523                $expected .= $uploads_dir_url . $size['file'] . ' ' . $size['width'] . 'w, ';
     
    15961596
    15971597        foreach ( $image_meta['sizes'] as $name => $size ) {
    1598             // Whitelist the sizes that should be included so we pick up 'medium_large' in 4.4.
     1598            // Allow the sizes that should be included so we pick up 'medium_large' in 4.4.
    15991599            if ( in_array( $name, $intermediates, true ) ) {
    16001600                $expected .= $uploads_dir_url . $year_month . '/' . $size['file'] . ' ' . $size['width'] . 'w, ';
     
    18751875
    18761876        foreach ( $image_meta['sizes'] as $name => $size ) {
    1877             // Whitelist the sizes that should be included so we pick up 'medium_large' in 4.4.
     1877            // Allow the sizes that should be included so we pick up 'medium_large' in 4.4.
    18781878            if ( in_array( $name, $intermediates, true ) ) {
    18791879                $expected .= $uploads_dir . $year_month . '/' . $size['file'] . ' ' . $size['width'] . 'w, ';
Note: See TracChangeset for help on using the changeset viewer.