Changeset 48121 for trunk/tests/phpunit/tests/post/attachments.php

Timestamp:

06/22/2020 05:24:34 PM (5 years ago)

Author:

desrosj

Message:

General: Remove “whitelist” and “blacklist” in favor of more clear and inclusive language.

“The WordPress open source community cares about diversity. We strive to maintain a welcoming environment where everyone can feel included.”

With this commit, all occurrences of “whitelist” and “blacklist” (with the single exception of the $new_whitelist_options global variable) are removed. A new ticket has been opened to explore renaming the $new_whitelist_options variable (#50434).

Changing to more specific names or rewording sentences containing these terms not only makes the code more inclusive, but also helps provide clarity. These terms are often ambiguous. What is being blocked or allowed is not always immediately clear. This can make it more difficult for non-native English speakers to read through the codebase.

Words matter. If one contributor feels more welcome because these terms are removed, this was worth the effort.

Props strangerstudios, jorbin, desrosj, joemcgill, timothyblynjacobs, ocean90, ayeshrajans, davidbaumwald, earnjam.
See #48900, #50434.
Fixes #50413.

File:

• trunk/tests/phpunit/tests/post/attachments.php (modified) (3 diffs)

trunk/tests/phpunit/tests/post/attachments.php

@@ -467 +467 @@
         // On Multisite, psd is not an allowed mime type by default.
         if ( is_multisite() ) {
-            add_filter( 'upload_mimes', array( $this, 'whitelist_psd_mime_type' ), 10, 2 );
+            add_filter( 'upload_mimes', array( $this, 'allow_psd_mime_type' ), 10, 2 );
         }
 
@@ -482 +482 @@
 
         if ( is_multisite() ) {
-            remove_filter( 'upload_mimes', array( $this, 'whitelist_psd_mime_type' ), 10, 2 );
+            remove_filter( 'upload_mimes', array( $this, 'allow_psd_mime_type' ), 10, 2 );
         }
     }
@@ -494 +494 @@
         $this->assertFalse( $upload['error'] );
 
-        add_filter( 'upload_mimes', array( $this, 'blacklist_jpg_mime_type' ) );
-
-        $upload = wp_upload_bits( wp_basename( $filename ), null, $contents );
-
-        remove_filter( 'upload_mimes', array( $this, 'blacklist_jpg_mime_type' ) );
+        add_filter( 'upload_mimes', array( $this, 'disallow_jpg_mime_type' ) );
+
+        $upload = wp_upload_bits( wp_basename( $filename ), null, $contents );
+
+        remove_filter( 'upload_mimes', array( $this, 'disallow_jpg_mime_type' ) );
 
         $this->assertNotEmpty( $upload['error'] );
     }
 
-    public function whitelist_psd_mime_type( $mimes ) {
+    public function allow_psd_mime_type( $mimes ) {
         $mimes['psd'] = 'application/octet-stream';
         return $mimes;
     }
 
-    public function blacklist_jpg_mime_type( $mimes ) {
+    public function disallow_jpg_mime_type( $mimes ) {
         unset( $mimes['jpg|jpeg|jpe'] );
         return $mimes;