Changeset 48121 for trunk/tests/phpunit/tests/rest-api.php

Timestamp:

06/22/2020 05:24:34 PM (4 years ago)

Author:

desrosj

Message:

General: Remove “whitelist” and “blacklist” in favor of more clear and inclusive language.

“The WordPress open source community cares about diversity. We strive to maintain a welcoming environment where everyone can feel included.”

With this commit, all occurrences of “whitelist” and “blacklist” (with the single exception of the $new_whitelist_options global variable) are removed. A new ticket has been opened to explore renaming the $new_whitelist_options variable (#50434).

Changing to more specific names or rewording sentences containing these terms not only makes the code more inclusive, but also helps provide clarity. These terms are often ambiguous. What is being blocked or allowed is not always immediately clear. This can make it more difficult for non-native English speakers to read through the codebase.

Words matter. If one contributor feels more welcome because these terms are removed, this was worth the effort.

Props strangerstudios, jorbin, desrosj, joemcgill, timothyblynjacobs, ocean90, ayeshrajans, davidbaumwald, earnjam.
See #48900, #50434.
Fixes #50413.

File:

• trunk/tests/phpunit/tests/rest-api.php (modified) (6 diffs)

trunk/tests/phpunit/tests/rest-api.php

@@ -379 +379 @@
 
     /**
-     * Ensure that result fields are not whitelisted if no request['_fields'] is present.
+     * Ensure that result fields are not allowed if no request['_fields'] is present.
      */
     public function test_rest_filter_response_fields_no_request_filter() {
@@ -391 +391 @@
 
     /**
-     * Ensure that result fields are whitelisted if request['_fields'] is present.
+     * Ensure that result fields are allowed if request['_fields'] is present.
      */
     public function test_rest_filter_response_fields_single_field_filter() {
@@ -411 +411 @@
 
     /**
-     * Ensure that multiple comma-separated fields may be whitelisted with request['_fields'].
+     * Ensure that multiple comma-separated fields may be allowed with request['_fields'].
      */
     public function test_rest_filter_response_fields_multi_field_filter() {
@@ -441 +441 @@
 
     /**
-     * Ensure that multiple comma-separated fields may be whitelisted
+     * Ensure that multiple comma-separated fields may be allowed
      * with request['_fields'] using query parameter array syntax.
      */
@@ -473 +473 @@
 
     /**
-     * Ensure that request['_fields'] whitelists apply to items in response collections.
+     * Ensure that request['_fields'] allowed list apply to items in response collections.
      */
     public function test_rest_filter_response_fields_numeric_array() {
@@ -521 +521 @@
 
     /**
-     * Ensure that nested fields may be whitelisted with request['_fields'].
+     * Ensure that nested fields may be allowed with request['_fields'].
      *
      * @ticket 42094