Changeset 48128

Timestamp:

06/22/2020 11:51:09 PM (6 years ago)

Author:

whyisjake

Message:

Media: Ensure that uploaded images get a success notification by users with upload_files capability.

There was an early wp_die that was preventing the success notification from being sent in the upload process.

Fixes #44581.

Props pbiron, mikeschroder, joemcgill, rebasaurus, whyisjake.

File:

• trunk/src/wp-admin/async-upload.php (modified) (2 diffs)

trunk/src/wp-admin/async-upload.php

@@ -46 +46 @@
                 wp_die( __( 'Invalid post type.' ) );
         }
-        if ( ! current_user_can( 'edit_post', $id ) ) {
-                wp_die( __( 'Sorry, you are not allowed to edit this item.' ) );
-        }
 
         switch ( $_REQUEST['fetch'] ) {
@@ -56 +53 @@
                                 echo '<img class="pinkynail" src="' . esc_url( $thumb_url[0] ) . '" alt="" />';
                         }
-                        echo '<a class="edit-attachment" href="' . esc_url( get_edit_post_link( $id ) ) . '" target="_blank">' . _x( 'Edit', 'media item' ) . '</a>';
+                        if ( current_user_can( 'edit_post', $id ) ) {
+                                echo '<a class="edit-attachment" href="' . esc_url( get_edit_post_link( $id ) ) . '" target="_blank">' . _x( 'Edit', 'media item' ) . '</a>';
+                        } else {
+                                echo '<span class="edit-attachment">' . _x( 'Success', 'media item' ) . '</span>';
+                        }
 
                         // Title shouldn't ever be empty, but use filename just in case.