Changeset 48151 for trunk/src/wp-admin/includes/class-wp-list-table.php

Timestamp:

06/23/2020 11:13:35 PM (6 years ago)

Author:

whyisjake

Message:

Administration: Update WP_List_Table::get_sortable_columns() to support asc and desc arguments.

This makes the API a little more clear, whereas setting false used to mean asc and true meant desc, you can now use those directly, while maintaining back-compat.

Fixes #45089.

Props Tkama, SergeyBiryukov, shital-patel, desrosj, birgire, davidbaumwald.

File:

• trunk/src/wp-admin/includes/class-wp-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -947 +947 @@
 
         /**
-         * Get a list of sortable columns. The format is:
-         * 'internal-name' => 'orderby'
-         * or
-         * 'internal-name' => array( 'orderby', true )
-         *
-         * The second format will make the initial sorting order be descending
+         * Get a list of sortable columns.
+         *
+         * The format is:
+         * - `'internal-name' => 'orderby'`
+         * - `'internal-name' => array( 'orderby', 'asc' )` - The second element set the initial sorting order.
+         * - `'internal-name' => array( 'orderby', true )` - The second element will make the initial sorting order be descending.
          *
          * @since 3.1.0
@@ -1162 +1162 @@
                                         $class[] = $current_order;
                                 } else {
-                                        $order   = $desc_first ? 'desc' : 'asc';
+                                        if ( in_array( strtolower( $desc_first ), array( 'desc', 'asc' ), true ) ) {
+                                                $order = 'asc' === strtolower( $desc_first ) ? 'desc' : 'asc';
+                                        } else {
+                                                $order = $desc_first ? 'desc' : 'asc';
+                                        }
                                         $class[] = 'sortable';
-                                        $class[] = $desc_first ? 'asc' : 'desc';
+                                        $class[] = 'desc' === $order ? 'asc' : 'desc';
                                 }