Changeset 48154 for trunk/tests/phpunit/tests/ajax/EditComment.php

Timestamp:

06/24/2020 12:03:33 AM (4 years ago)

Author:

whyisjake

Message:

Comments: Allow wp_update_comment() to return WP_Error().

The wp_update_comment_data filter introduced in 4.7 allows comment data to be filtered before it is updated in the database.

The patch aims to handle WP_Error as the filter above return value in a similar manner as is done for wp_new_comment().

Fixes #39732.

Props: enricosorcinelli, swissspidy, gkloveweb, jnylen0, jbpaul17, afercia, SergeyBiryukov, audrasjb, imath, davidbaumwald.

File:

• trunk/tests/phpunit/tests/ajax/EditComment.php (modified) (2 diffs)

trunk/tests/phpunit/tests/ajax/EditComment.php

@@ -33 +33 @@
     }
 
+    public function tearDown() {
+        remove_filter( 'wp_update_comment_data', array( $this, '_wp_update_comment_data_filter' ), 10, 3 );
+        parent::tearDown();
+    }
+
     /**
      * Get comments as a privilged user (administrator)
@@ -128 +133 @@
 
     /**
+     * @ticket 39732
+     */
+    public function test_wp_update_comment_data_is_wp_error() {
+        // Become an administrator
+        $this->_setRole( 'administrator' );
+
+        // Get a comment
+        $comments = get_comments(
+            array(
+                'post_id' => $this->_comment_post->ID,
+            )
+        );
+        $comment  = array_pop( $comments );
+
+        // Set up a default request
+        $_POST['_ajax_nonce-replyto-comment'] = wp_create_nonce( 'replyto-comment' );
+        $_POST['comment_ID']                  = $comment->comment_ID;
+        $_POST['content']                     = 'Lorem ipsum dolor sit amet, consectetur adipiscing elit.';
+
+        // Simulate filter check error
+        add_filter( 'wp_update_comment_data', array( $this, '_wp_update_comment_data_filter' ), 10, 3 );
+
+        // Make the request
+        $this->setExpectedException( 'WPAjaxDieStopException', 'wp_update_comment_data filter fails for this comment.' );
+        $this->_handleAjax( 'edit-comment' );
+    }
+
+    /**
+     * Block comments from being updated by returning WP_Error
+     */
+    public function _wp_update_comment_data_filter( $data, $comment, $commentarr ) {
+        return new WP_Error( 'comment_wrong', __( 'wp_update_comment_data filter fails for this comment.' ), 500 );
+    }
+
+    /**
      * Get comments as a non-privileged user (subscriber)
      * Expects test to fail