Changeset 48154 for trunk/tests/phpunit/tests/comment.php

Timestamp:

06/24/2020 12:03:33 AM (10 months ago)

Author:

whyisjake

Message:

Comments: Allow wp_update_comment() to return WP_Error().

The wp_update_comment_data filter introduced in 4.7 allows comment data to be filtered before it is updated in the database.

The patch aims to handle WP_Error as the filter above return value in a similar manner as is done for wp_new_comment().

Fixes #39732.

Props: enricosorcinelli, swissspidy, gkloveweb, jnylen0, jbpaul17, afercia, SergeyBiryukov, audrasjb, imath, davidbaumwald.

File:

• trunk/tests/phpunit/tests/comment.php (modified) (1 diff)

trunk/tests/phpunit/tests/comment.php

@@ -141 +141 @@
         $comment = get_comment( $comment_id );
         $this->assertEquals( $updated_comment_text, $comment->comment_content );
+    }
+
+    /**
+     * @ticket 39732
+     */
+    public function test_wp_update_comment_is_wp_error() {
+        $comment_id = self::factory()->comment->create( array( 'comment_post_ID' => self::$post_id ) );
+
+        add_filter( 'wp_update_comment_data', array( $this, '_wp_update_comment_data_filter' ), 10, 3 );
+        $result = wp_update_comment(
+            array(
+                'comment_ID'   => $comment_id,
+                'comment_type' => 'pingback',
+            ),
+            true
+        );
+        $this->assertWPError( $result );
+        remove_filter( 'wp_update_comment_data', array( $this, '_wp_update_comment_data_filter' ), 10, 3 );
+    }
+
+    /**
+     * Block comments from being updated by returning WP_Error
+     */
+    public function _wp_update_comment_data_filter( $data, $comment, $commentarr ) {
+        return new WP_Error( 'comment_wrong', __( 'wp_update_comment_data filter fails for this comment.' ), 500 );
     }