Changeset 48154 for trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

Timestamp:

06/24/2020 12:03:33 AM (5 years ago)

Author:

whyisjake

Message:

Comments: Allow wp_update_comment() to return WP_Error().

The wp_update_comment_data filter introduced in 4.7 allows comment data to be filtered before it is updated in the database.

The patch aims to handle WP_Error as the filter above return value in a similar manner as is done for wp_new_comment().

Fixes #39732.

Props: enricosorcinelli, swissspidy, gkloveweb, jnylen0, jbpaul17, afercia, SergeyBiryukov, audrasjb, imath, davidbaumwald.

File:

• trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

@@ -2791 +2791 @@
     }
 
+    /**
+     * @ticket 39732
+     */
+    public function test_update_comment_is_wp_error() {
+        wp_set_current_user( self::$admin_id );
+
+        $params = array(
+            'content' => 'This isn\'t a saxophone. It\'s an umbrella.',
+        );
+
+        add_filter( 'wp_update_comment_data', array( $this, '_wp_update_comment_data_filter' ), 10, 3 );
+
+        $request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/comments/%d', self::$approved_id ) );
+
+        $request->add_header( 'content-type', 'application/json' );
+        $request->set_body( wp_json_encode( $params ) );
+        $response = rest_get_server()->dispatch( $request );
+
+        $this->assertErrorResponse( 'rest_comment_failed_edit', $response, 500 );
+
+        remove_filter( 'wp_update_comment_data', array( $this, '_wp_update_comment_data_filter' ), 10, 3 );
+    }
+
+    /**
+     * Block comments from being updated by returning WP_Error
+     */
+    public function _wp_update_comment_data_filter( $data, $comment, $commentarr ) {
+        return new WP_Error( 'comment_wrong', __( 'wp_update_comment_data filter fails for this comment.' ), array( 'status' => 500 ) );
+    }
+
     public function verify_comment_roundtrip( $input = array(), $expected_output = array() ) {
         // Create the comment.