Changeset 48165 for trunk/tests/phpunit/tests/admin/includesListTable.php

Timestamp:

06/25/2020 11:33:23 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Administration: Correct and simplify the logic for asc and desc arguments in WP_List_Table::get_sortable_columns().

Setting the initial order didn't work as expected due to reversed logic.

Follow-up to [48151].

See #45089.

File:

• trunk/tests/phpunit/tests/admin/includesListTable.php (modified) (2 diffs)

trunk/tests/phpunit/tests/admin/includesListTable.php

@@ -304 +304 @@
             'author'   => array( 'comment_author', true ),
             'response' => 'comment_post_ID',
-            'date'     => array( 'comment_date', 'dEsC' ), // The ordering support should be case insensitive.
+            'date'     => array( 'comment_date', 'dEsC' ), // The ordering support should be case-insensitive.
         );
 
@@ -325 +325 @@
         $this->assertContains( 'column-response sortable desc', $output, 'Mismatch of CSS classes for the comment post ID column.' );
 
-        $this->assertContains( '?orderby=comment_date&order=asc', $output, 'Mismatch of the default link ordering for comment author column. Should be asc.' );
-        $this->assertContains( 'column-date sortable desc', $output, 'Mismatch of CSS classes for the comment date column.' );
+        $this->assertContains( '?orderby=comment_date&order=desc', $output, 'Mismatch of the default link ordering for comment date column. Should be asc.' );
+        $this->assertContains( 'column-date sortable asc', $output, 'Mismatch of CSS classes for the comment date column.' );
     }