Changeset 48203 for trunk/src/wp-admin/includes/class-wp-posts-list-table.php

Timestamp:

06/28/2020 02:28:23 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Posts, Post Types: Return early from WP_Posts_List_Table::formats_dropdown() if the post type does not support post formats.

This avoids an unnecessary database query for the post_format taxonomy.

Props Chouby.
Fixes #50496.

File:

• trunk/src/wp-admin/includes/class-wp-posts-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -486 +486 @@
         }
 
+        // Return if the post type doesn't have post formats or if we're in the Trash.
+        if ( ! is_object_in_taxonomy( $post_type, 'post_format' ) || $this->is_trash ) {
+            return;
+        }
+
         // Make sure the dropdown shows only formats with a post count greater than 0.
         $used_post_formats = get_terms(
@@ -494 +499 @@
         );
 
-        /*
-         * Return if the post type doesn't have post formats, or there are no posts using formats,
-         * or if we're in the Trash.
-         */
-        if ( ! is_object_in_taxonomy( $post_type, 'post_format' ) || ! $used_post_formats || $this->is_trash ) {
+        // Return if there are no posts using formats.
+        if ( ! $used_post_formats ) {
             return;
         }