Changeset 48204

Timestamp:

06/28/2020 06:23:39 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Introduce the spread operator in wp-includes/IXR.

Rather than relying func_get_args() to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props kraftbj.
See #48267, #47678.

Location:

trunk/src/wp-includes/IXR

Files:

• class-IXR-client.php (modified) (1 diff)
• class-IXR-clientmulticall.php (modified) (2 diffs)

trunk/src/wp-includes/IXR/class-IXR-client.php

@@ -59 +59 @@
     }
 
-    function query()
+    /**
+     * @since 1.5.0
+     * @since 5.5.0 Formalized the existing `...$args` parameter by adding it
+     *              to the function signature.
+     */
+    function query( ...$args )
     {
-        $args = func_get_args();
         $method = array_shift($args);
         $request = new IXR_Request($method, $args);

trunk/src/wp-includes/IXR/class-IXR-clientmulticall.php

@@ -26 +26 @@
     }
 
-    function addCall()
+    /**
+     * @since 1.5.0
+     * @since 5.5.0 Formalized the existing `...$args` parameter by adding it
+     *              to the function signature.
+     */
+    function addCall( ...$args )
     {
-        $args = func_get_args();
         $methodName = array_shift($args);
         $struct = array(
@@ -37 +41 @@
     }
 
-    function query()
+    /**
+     * @since 1.5.0
+     * @since 5.5.0 Formalized the existing `...$args` parameter by adding it
+     *              to the function signature.
+     */
+    function query( ...$args )
     {
         // Prepare multicall, then call the parent::query() method