Changeset 48234 for trunk/src/wp-admin/includes/class-wp-privacy-policy-content.php

Timestamp:

06/30/2020 01:54:40 PM (4 years ago)

Author:

afercia

Message:

Accessibility: Privacy: Accessibility improvements for the Privacy Policy Guide page.

Improves accessibility of the "Copy this section" button and "Return to Top" link:

• uses setTimeout() and clearTimeout() to properly handle the "Copied!" text
• simplifies the button text by removing the redundant visually hidden text
• fixes the mismatching visual and DOM order of the Copy button and the "Return to Top" link
• improves the "Return to Top" links by providing real page fragment identifiers, when possible
• hides the "Return to Top" up arrow from assistive technologies
• minor coding standards

Props afercia, garrett-eclipse.
See #48463, #50322.
Fixes #50335.

File:

• trunk/src/wp-admin/includes/class-wp-privacy-policy-content.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-privacy-policy-content.php

@@ -413 +413 @@
 
             $content .= '<div class="policy-text">' . $section['policy_text'] . '</div>';
-            $content .= '<a href="#" class="return-to-top">' . __( '&uarr; Return to Top' ) . '</a>';
 
             if ( empty( $section['removed'] ) ) {
@@ -419 +418 @@
                 $content .= '<button type="button" class="privacy-text-copy button">';
                 $content .= __( 'Copy this section to clipboard' );
-                $content .= '<span class="screen-reader-text">';
-                /* translators: %s: Plugin name. */
-                $content .= sprintf( __( 'Copy suggested policy text from %s.' ), $plugin_name );
-                $content .= '</span>';
                 $content .= '</button>';
                 $content .= '<span class="success" aria-hidden="true">' . __( 'Copied!' ) . '</span>';
                 $content .= '</div>';
             }
+
+            $content .= '<a href="#wpbody" class="return-to-top"><span aria-hidden="true">&uarr; </span> ' . __( 'Return to Top' ) . '</a>';
 
             $content .= '</div>'; // End of .privacy-text-section.