Changeset 48234 for trunk/src/wp-admin/includes/privacy-tools.php

Timestamp:

06/30/2020 01:54:40 PM (5 years ago)

Author:

afercia

Message:

Accessibility: Privacy: Accessibility improvements for the Privacy Policy Guide page.

Improves accessibility of the "Copy this section" button and "Return to Top" link:

• uses setTimeout() and clearTimeout() to properly handle the "Copied!" text
• simplifies the button text by removing the redundant visually hidden text
• fixes the mismatching visual and DOM order of the Copy button and the "Return to Top" link
• improves the "Return to Top" links by providing real page fragment identifiers, when possible
• hides the "Return to Top" up arrow from assistive technologies
• minor coding standards

Props afercia, garrett-eclipse.
See #48463, #50322.
Fixes #50335.

File:

• trunk/src/wp-admin/includes/privacy-tools.php (modified) (2 diffs)

trunk/src/wp-admin/includes/privacy-tools.php

@@ -279 +279 @@
 
     if ( 1 < $groups_count ) {
-        $group_html .= '<div class="return_to_top">';
-        $group_html .= '<a href="#top">' . esc_html__( '&uarr; Return to top' ) . '</a>';
+        $group_html .= '<div class="return-to-top">';
+        $group_html .= '<a href="#top"><span aria-hidden="true">&uarr; </span> ' . esc_html__( 'Return to top' ) . '</a>';
         $group_html .= '</div>';
     }
@@ -424 +424 @@
     fwrite( $file, 'td { padding: 5px; }' );
     fwrite( $file, 'tr:nth-child(odd) { background-color: #fafafa; }' );
-    fwrite( $file, '.return_to_top { text-align:right; }' );
+    fwrite( $file, '.return-to-top { text-align: right; }' );
     fwrite( $file, '</style>' );
     fwrite( $file, '<title>' );