Changeset 48238

Timestamp:

06/30/2020 07:48:48 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Introduce the spread operator in WP_HTTP_IXR_Client.

Rather than relying func_get_args() to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

This makes the signature of WP_HTTP_IXR_Client::query() compatible with the parent class method.

Follow-up to [48204].

Props ayeshrajans.
See #48267, #47678.

Location:

trunk/src/wp-includes

Files:

• IXR/class-IXR-client.php (modified) (1 diff)
• IXR/class-IXR-clientmulticall.php (modified) (1 diff)
• class-wp-http-ixr-client.php (modified) (1 diff)

trunk/src/wp-includes/IXR/class-IXR-client.php

@@ -63 +63 @@
      * @since 5.5.0 Formalized the existing `...$args` parameter by adding it
      *              to the function signature.
+     *
+     * @return bool
      */
     function query( ...$args )

trunk/src/wp-includes/IXR/class-IXR-clientmulticall.php

@@ -45 +45 @@
      * @since 5.5.0 Formalized the existing `...$args` parameter by adding it
      *              to the function signature.
+     *
+     * @return bool
      */
     function query( ...$args )

trunk/src/wp-includes/class-wp-http-ixr-client.php

@@ -47 +47 @@
 
     /**
+     * @since 3.1.0
+     * @since 5.5.0 Formalized the existing `...$args` parameter by adding it
+     *              to the function signature.
+     *
      * @return bool
      */
-    public function query() {
-        $args    = func_get_args();
+    public function query( ...$args ) {
         $method  = array_shift( $args );
         $request = new IXR_Request( $method, $args );