Changeset 48240

Timestamp:

06/30/2020 08:33:32 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Administration: Always show the filters on media and post list tables.

Previously, the filters were hidden for single posts or attachments, which could only be achieved by editing the URL manually.

The is_singular() check was added long before the list tables were introduced, and appears to no longer serve any purpose in the current code.

As a side effect, this resolves an issue where a non-existing attachment ID in the URL would block further search in Media Library.

Props afercia, tomdude, audrasjb, bencroskery, desrosj, SergeyBiryukov.
Fixes #38221.

Location:

trunk/src/wp-admin/includes

Files:

• class-wp-media-list-table.php (modified) (1 diff)
• class-wp-posts-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-media-list-table.php

@@ -175 +175 @@
         <div class="actions">
         <?php
-        if ( ! is_singular() ) {
-            if ( ! $this->is_trash ) {
-                $this->months_dropdown( 'attachment' );
-            }
-
-            /** This action is documented in wp-admin/includes/class-wp-posts-list-table.php */
-            do_action( 'restrict_manage_posts', $this->screen->post_type, $which );
-
-            submit_button( __( 'Filter' ), '', 'filter_action', false, array( 'id' => 'post-query-submit' ) );
-        }
+        if ( ! $this->is_trash ) {
+            $this->months_dropdown( 'attachment' );
+        }
+
+        /** This action is documented in wp-admin/includes/class-wp-posts-list-table.php */
+        do_action( 'restrict_manage_posts', $this->screen->post_type, $which );
+
+        submit_button( __( 'Filter' ), '', 'filter_action', false, array( 'id' => 'post-query-submit' ) );
 
         if ( $this->is_trash && current_user_can( 'edit_others_posts' ) && $this->has_items() ) {

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -535 +535 @@
         <div class="alignleft actions">
         <?php
-        if ( 'top' === $which && ! is_singular() ) {
+        if ( 'top' === $which ) {
             ob_start();