Changeset 48266

Timestamp:

07/01/2020 07:28:14 PM (6 years ago)

Author:

ocean90

Message:

I18N: Use wp.i18n for translatable strings in wp-includes/js/wp-pointer.js.

This removes the usage of wp_localize_script() for passing translations to the script and instead adds the translatable strings in the script directly through the use of wp.i18n and its utilities.

Props swissspidy, ocean90.
See #20491.
Fixes #50525.

Location:

trunk/src

Files:

• js/_enqueues/lib/pointer.js (modified) (2 diffs)
• wp-includes/script-loader.php (modified) (1 diff)

trunk/src/js/_enqueues/lib/pointer.js

@@ -2 +2 @@
  * @output wp-includes/js/wp-pointer.js
  */
-
-/* global wpPointerL10n */
 
 /**
@@ -20 +18 @@
             },
             buttons: function( event, t ) {
-                var close  = ( wpPointerL10n ) ? wpPointerL10n.dismiss : 'Dismiss',
-                    button = $('<a class="close" href="#">' + close + '</a>');
+                var button = $('<a class="close" href="#"></a>').text( wp.i18n.__( 'Dismiss' ) );
 
                 return button.bind( 'click.pointer', function(e) {

trunk/src/wp-includes/script-loader.php

@@ -689 +689 @@
     );
 
-    $scripts->add( 'wp-pointer', "/wp-includes/js/wp-pointer$suffix.js", array( 'jquery-ui-widget', 'jquery-ui-position' ), '20111129a', 1 );
-    did_action( 'init' ) && $scripts->localize(
-        'wp-pointer',
-        'wpPointerL10n',
-        array(
-            'dismiss' => __( 'Dismiss' ),
-        )
-    );
+    $scripts->add( 'wp-pointer', "/wp-includes/js/wp-pointer$suffix.js", array( 'jquery-ui-widget', 'jquery-ui-position' ), false, 1 );
+    $scripts->set_translations( 'wp-pointer' );
 
     $scripts->add( 'autosave', "/wp-includes/js/autosave$suffix.js", array( 'heartbeat' ), false, 1 );