Changeset 48267 for trunk/src/wp-includes/script-loader.php

Timestamp:

07/01/2020 07:48:30 PM (6 years ago)

Author:

ocean90

Message:

I18N: Use wp.i18n for translatable strings in wp-admin/js/common.js.

This removes the usage of wp_localize_script() for passing translations to the script and instead adds the translatable strings in the script directly through the use of wp.i18n and its utilities.

Props swissspidy, ocean90.
See #20491.
Fixes #50526.

File:

• trunk/src/wp-includes/script-loader.php (modified) (2 diffs)

trunk/src/wp-includes/script-loader.php

@@ -609 +609 @@
 
     $scripts->add( 'common', "/wp-admin/js/common$suffix.js", array( 'jquery', 'hoverIntent', 'utils' ), false, 1 );
-    did_action( 'init' ) && $scripts->localize(
-        'common',
-        'commonL10n',
-        array(
-            'warnDelete'   => __( "You are about to permanently delete these items from your site.\nThis action cannot be undone.\n 'Cancel' to stop, 'OK' to delete." ),
-            'dismiss'      => __( 'Dismiss this notice.' ),
-            'collapseMenu' => __( 'Collapse Main menu' ),
-            'expandMenu'   => __( 'Expand Main menu' ),
-        )
-    );
+    $scripts->set_translations( 'common' );
 
     $scripts->add( 'wp-sanitize', "/wp-includes/js/wp-sanitize$suffix.js", array(), false, 1 );
@@ -810 +801 @@
     // Masonry v2 depended on jQuery. v3 does not. The older jquery-masonry handle is a shiv.
     // It sets jQuery as a dependency, as the theme may have been implicitly loading it this way.
-    $scripts->add( 'imagesloaded', '/wp-includes/js/imagesloaded.min.js', array(), '4.1.4', 1 );
-    $scripts->add( 'masonry', '/wp-includes/js/masonry.min.js', array( 'imagesloaded' ), '4.2.2', 1 );
+    $scripts->add( 'imagesloaded', '/wp-includes/js/imagesloaded.min.js', array(), '3.2.0', 1 );
+    $scripts->add( 'masonry', '/wp-includes/js/masonry.min.js', array( 'imagesloaded' ), '3.3.2', 1 );
     $scripts->add( 'jquery-masonry', "/wp-includes/js/jquery/jquery.masonry$dev_suffix.js", array( 'jquery', 'masonry' ), '3.1.2b', 1 );