Changeset 48270

Timestamp:

07/01/2020 08:36:32 PM (6 years ago)

Author:

ocean90

Message:

I18N: Use wp.i18n for translatable strings in wp-admin/js/user-profile.js.

This removes the usage of wp_localize_script() for passing translations to the script and instead adds the translatable strings in the script directly through the use of wp.i18n and its utilities.

Props swissspidy, ocean90.
See #20491.
Fixes #50527.

Location:

trunk/src

Files:

• js/_enqueues/admin/user-profile.js (modified) (4 diffs)
• wp-includes/script-loader.php (modified) (1 diff)

trunk/src/js/_enqueues/admin/user-profile.js

@@ -3 +3 @@
  */
 
-/* global ajaxurl, pwsL10n, userProfileL10n */
+/* global ajaxurl, pwsL10n */
 (function($) {
         var updateLock = false,
-
+                __ = wp.i18n.__,
                 $pass1Row,
                 $pass1,
@@ -40 +40 @@
 
                 // Once zxcvbn loads, passwords strength is known.
-                $( '#pw-weak-text-label' ).html( userProfileL10n.warnWeak );
+                $( '#pw-weak-text-label' ).text( __( 'Confirm use of weak password' ) );
         }
 
@@ -65 +65 @@
                 $toggleButton
                         .attr({
-                                'aria-label': show ? userProfileL10n.ariaShow : userProfileL10n.ariaHide
+                                'aria-label': show ? __( 'Show password' ) : __( 'Hide password' )
                         })
                         .find( '.text' )
-                                .text( show ? userProfileL10n.show : userProfileL10n.hide )
+                                .text( show ? __( 'Show' ) : __( 'Hide' ) )
                         .end()
                         .find( '.dashicons' )
@@ -403 +403 @@
         $( window ).on( 'beforeunload', function () {
                 if ( true === updateLock ) {
-                        return userProfileL10n.warn;
+                        return __( 'Your new password has not been saved.' );
                 }
         } );

trunk/src/wp-includes/script-loader.php

@@ -1066 +1066 @@
 
         $scripts->add( 'user-profile', "/wp-admin/js/user-profile$suffix.js", array( 'jquery', 'password-strength-meter', 'wp-util' ), false, 1 );
-        did_action( 'init' ) && $scripts->localize(
-                'user-profile',
-                'userProfileL10n',
-                array(
-                        'warn'     => __( 'Your new password has not been saved.' ),
-                        'warnWeak' => __( 'Confirm use of weak password' ),
-                        'show'     => __( 'Show' ),
-                        'hide'     => __( 'Hide' ),
-                        'cancel'   => __( 'Cancel' ),
-                        'ariaShow' => esc_attr__( 'Show password' ),
-                        'ariaHide' => esc_attr__( 'Hide password' ),
-                )
-        );
+        $scripts->set_translations( 'user-profile' );
 
         $scripts->add( 'language-chooser', "/wp-admin/js/language-chooser$suffix.js", array( 'jquery' ), false, 1 );