Changeset 48283

Timestamp:

07/03/2020 12:56:43 PM (4 years ago)

Author:

afercia

Message:

Accessibility: Themes: Use a default empty alt attribute for the non-linked custom logo on the home page.

After [48039] it became clear that the non-linked custom logo on the home page needs an empty alt attribute, as in most of the cases the logo is decorative and doesn't need its purpose to be described.

This change outputs an empty alt attribute by default for the custom logo on the home page. If necessary, it is possible to use the new 'get_custom_logo_image_attributes' filter to manipulate the default attributes for the logo image and set an alt attribute.

Props FlorianBrinkmann, Soean, sabernhardt, audrasjb, SergeyBiryukov, samful, knutsp.
See #36640.
Fixes #37011.

File:

• trunk/src/wp-includes/general-template.php (modified) (1 diff)

trunk/src/wp-includes/general-template.php

@@ -982 +982 @@
         );
 
-        /*
-         * If the logo alt attribute is empty, get the site title and explicitly pass it
-         * to the attributes used by wp_get_attachment_image().
-         */
-        $image_alt = get_post_meta( $custom_logo_id, '_wp_attachment_image_alt', true );
-        if ( empty( $image_alt ) ) {
-            $custom_logo_attr['alt'] = get_bloginfo( 'name', 'display' );
+        if ( is_front_page() ) {
+            /*
+             * If on the home page, set the logo alt attribute to an empty string,
+             * as the image is decorative and doesn't need its purpose to be described.
+             */
+            $custom_logo_attr['alt'] = '';
+        } else {
+            /*
+             * If the logo alt attribute is empty, get the site title and explicitly pass it
+             * to the attributes used by wp_get_attachment_image().
+             */
+            $image_alt = get_post_meta( $custom_logo_id, '_wp_attachment_image_alt', true );
+            if ( empty( $image_alt ) ) {
+                $custom_logo_attr['alt'] = get_bloginfo( 'name', 'display' );
+            }
         }