Changeset 48285

Timestamp:

07/03/2020 07:03:23 PM (3 years ago)

Author:

ocean90

Message:

I18N: Use wp.i18n for translatable strings in wp-includes/js/wp-auth-check.js.

This removes the usage of wp_localize_script() for passing translations to the script and instead adds the translatable strings in the script directly through the use of wp.i18n and its utilities.

Props swissspidy, ocean90.
See #20491.
Fixes #50553.

Location:

trunk/src

Files:

• js/_enqueues/lib/auth-check.js (modified) (1 diff)
• wp-includes/script-loader.php (modified) (1 diff)

trunk/src/js/_enqueues/lib/auth-check.js

@@ -24 +24 @@
             // Add unload confirmation to counter (frame-busting) JS redirects.
             $(window).on( 'beforeunload.wp-auth-check', function(e) {
-                e.originalEvent.returnValue = window.authcheckL10n.beforeunload;
+                e.originalEvent.returnValue = wp.i18n.__( 'Your session has expired. You can log in again from this page or go to the login page.' );
             });
 

trunk/src/wp-includes/script-loader.php

@@ -700 +700 @@
 
     $scripts->add( 'wp-auth-check', "/wp-includes/js/wp-auth-check$suffix.js", array( 'heartbeat' ), false, 1 );
-    did_action( 'init' ) && $scripts->localize(
-        'wp-auth-check',
-        'authcheckL10n',
-        array(
-            'beforeunload' => __( 'Your session has expired. You can log in again from this page or go to the login page.' ),
-        )
-    );
+    $scripts->set_translations( 'wp-auth-check' );
 
     $scripts->add( 'wp-lists', "/wp-includes/js/wp-lists$suffix.js", array( 'wp-ajax-response', 'jquery-color' ), false, 1 );