Changeset 48308

Timestamp:

07/05/2020 01:04:30 AM (3 years ago)

Author:

TimothyBlynJacobs

Message:

REST API: Remove specific multi-type schema handling from the themes controller.

Multi-type schema handling was improved in [48306]. In particular, it now allows for sanitizing a multi-typed value that wouldn't validate. Removing this handling will make 3rd party registered theme features more robust.

Fixes #50562.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-themes-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-themes-controller.php

@@ -237 +237 @@
         }
 
-        if ( is_array( $support ) ) {
-            if ( ! $args['variadic'] ) {
-                $support = $support[0];
-            }
-
-            // Multi-type theme-support schema definitions always list boolean first.
-            if ( is_array( $schema['type'] ) && 'boolean' === $schema['type'][0] ) {
-                // Pass the non-boolean type through to the sanitizer, which cannot itself
-                // determine the intended type if the value is invalid (for example if an
-                // object includes non-safelisted properties). See #50300.
-                $schema['type'] = $schema['type'][1];
-            }
+        if ( is_array( $support ) && ! $args['variadic'] ) {
+            $support = $support[0];
         }