Changeset 48347

Timestamp:

07/06/2020 07:45:04 PM (4 years ago)

Author:

ocean90

Message:

I18N: Use wp.i18n for translatable strings in wp-admin/js/tags.js.

This removes the usage of wp_localize_script() for passing translations to the script and instead adds the translatable strings in the script directly through the use of wp.i18n and its utilities.

Props swissspidy, ocean90.
See #20491.
Fixes #50577.

Location:

trunk/src

Files:

• js/_enqueues/admin/tags.js (modified) (2 diffs)
• wp-includes/script-loader.php (modified) (1 diff)

trunk/src/js/_enqueues/admin/tags.js

@@ -8 +8 @@
  */
 
- /* global ajaxurl, wpAjax, tagsl10n, showNotice, validateForm */
+ /* global ajaxurl, wpAjax, showNotice, validateForm */
 
 jQuery(document).ready(function($) {
@@ -56 +56 @@
 
                 } else if ( '-1' == r ) {
-                    $('#ajax-response').empty().append('<div class="error"><p>' + tagsl10n.noPerm + '</p></div>');
+                    $('#ajax-response').empty().append('<div class="error"><p>' + wp.i18n.__( 'Sorry, you are not allowed to do that.' ) + '</p></div>');
                     tr.children().css('backgroundColor', '');
 
                 } else {
-                    $('#ajax-response').empty().append('<div class="error"><p>' + tagsl10n.broken + '</p></div>');
+                    $('#ajax-response').empty().append('<div class="error"><p>' + wp.i18n.__( 'Something went wrong.' ) + '</p></div>');
                     tr.children().css('backgroundColor', '');
                 }

trunk/src/wp-includes/script-loader.php

@@ -1194 +1194 @@
     if ( is_admin() ) {
         $scripts->add( 'admin-tags', "/wp-admin/js/tags$suffix.js", array( 'jquery', 'wp-ajax-response' ), false, 1 );
-        did_action( 'init' ) && $scripts->localize(
-            'admin-tags',
-            'tagsl10n',
-            array(
-                'noPerm' => __( 'Sorry, you are not allowed to do that.' ),
-                'broken' => __( 'Something went wrong.' ),
-            )
-        );
+        $scripts->set_translations( 'admin-tags' );
 
         $scripts->add( 'admin-comments', "/wp-admin/js/edit-comments$suffix.js", array( 'wp-lists', 'quicktags', 'jquery-query' ), false, 1 );