Changeset 48375 for trunk/src/wp-admin/includes/ajax-actions.php

Timestamp:

07/07/2020 01:43:43 PM (6 years ago)

Author:

afercia

Message:

Accessibility: Media: Improve accessibility of the status and error messages in the Image Editor.

• improves focus management by moving focus to the notices, if any, or to the first "tabbable" element
• this avoids a focus loss and helps Braille-only and screen magnification users to be aware of the messages
• adds an ARIA role alert to all the notices
• uses wp.a11y.speak() to announce messages to assistive technology
• this way, all visual users will see the messages while assistive technology users will get an audible message
• uses wp.i18n for translatable strings in wp-admin/js/image-edit.js

Props anevins, ryanshoover, antpb, SergeyBiryukov, afercia.
See #20491.
Fixes #47147.

File:

• trunk/src/wp-admin/includes/ajax-actions.php (modified) (2 diffs)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -2608 +2608 @@
                 case 'save':
                         $msg = wp_save_image( $attachment_id );
-                        $msg = wp_json_encode( $msg );
-                        wp_die( $msg );
+                        if ( $msg->error ) {
+                                wp_send_json_error( $msg );
+                        }
+
+                        wp_send_json_success( $msg );
                         break;
                 case 'scale':
@@ -2619 +2622 @@
         }
 
+        ob_start();
         wp_image_editor( $attachment_id, $msg );
-        wp_die();
+        $html = ob_get_clean();
+
+        if ( $msg->error ) {
+                wp_send_json_error(
+                        array(
+                                'message' => $msg,
+                                'html'    => $html,
+                        )
+                );
+        }
+
+        wp_send_json_success(
+                array(
+                        'message' => $msg,
+                        'html'    => $html,
+                )
+        );
 }