Changeset 48384

Timestamp:

07/07/2020 04:12:14 PM (6 years ago)

Author:

ocean90

Message:

I18N: Use wp.i18n for translatable strings in wp-admin/js/media.js.

This removes the usage of wp_localize_script() for passing translations to the script and instead adds the translatable strings in the script directly through the use of wp.i18n and its utilities.

Props swissspidy, ocean90.
See #20491.
Fixes #50597.

Location:

trunk/src

Files:

• js/_enqueues/admin/media.js (modified) (2 diffs)
• wp-includes/script-loader.php (modified) (1 diff)

trunk/src/js/_enqueues/admin/media.js

@@ -11 +11 @@
  */
 
-/* global ajaxurl, attachMediaBoxL10n, _wpMediaGridSettings, showNotice, findPosts */
+/* global ajaxurl, _wpMediaGridSettings, showNotice, findPosts */
 
 ( function( $ ){
@@ -125 +125 @@
                         }).done( function( x ) {
                                 if ( ! x.success ) {
-                                        $( '#find-posts-response' ).text( attachMediaBoxL10n.error );
+                                        $( '#find-posts-response' ).text( wp.i18n.__( 'An error has occurred. Please reload the page and try again.' ) );
                                 }
 
                                 $( '#find-posts-response' ).html( x.data );
                         }).fail( function() {
-                                $( '#find-posts-response' ).text( attachMediaBoxL10n.error );
+                                $( '#find-posts-response' ).text( wp.i18n.__( 'An error has occurred. Please reload the page and try again.' ) );
                         });
                 }

trunk/src/wp-includes/script-loader.php

@@ -1358 +1358 @@
                 $scripts->add( 'media-grid', "/wp-includes/js/media-grid$suffix.js", array( 'media-editor' ), false, 1 );
                 $scripts->add( 'media', "/wp-admin/js/media$suffix.js", array( 'jquery' ), false, 1 );
-                did_action( 'init' ) && $scripts->localize(
-                        'media',
-                        'attachMediaBoxL10n',
-                        array(
-                                'error' => __( 'An error has occurred. Please reload the page and try again.' ),
-                        )
-                );
+                $scripts->set_translations( 'media' );
 
                 $scripts->add( 'image-edit', "/wp-admin/js/image-edit$suffix.js", array( 'jquery', 'jquery-ui-core', 'json2', 'imgareaselect', 'wp-a11y' ), false, 1 );