WordPress.org

Make WordPress Core

Changeset 48389


Ignore:
Timestamp:
07/07/2020 05:27:38 PM (3 months ago)
Author:
afercia
Message:

Accessibility: Widgets: Further improve spacing between Widgets checkboxes and radio buttons in the admin interface.

Follow-up to [47598]:

  • further improves the spacing after [47598] by better scoping the CSS to avoid layout glitches for custom widgets
  • changes the RSS widget form to wrap the checkboxes in one single paragraph

Ideally, multiple related checkboxes and radio buttons should be grouped within a fieldset element with a legend. This will be addressed in a new Trac ticket.

Props mukesh27, SergeyBiryukov, sabernhardt.
Fixes #49228.

Location:
trunk/src
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/css/widgets.css

    r48293 r48389  
    4747    padding: 1px 15px 15px 15px;
    4848    line-height: 1.23076923;
    49 }
    50 
    51 .widgets-holder-wrap .widget-inside label {
    52     margin: 0.25em 0 0.5em;
    53     display: inline-block;
    5449}
    5550
     
    797792-------------------------------------------------------------- */
    798793
     794@media screen and (max-width: 782px) {
     795    .widgets-holder-wrap .widget-inside input[type="checkbox"],
     796    .widgets-holder-wrap .widget-inside input[type="radio"],
     797    .editwidget .widget-inside input[type="checkbox"], /* Selectors for the "accessibility mode" page. */
     798    .editwidget .widget-inside input[type="radio"] {
     799        margin: 0.25rem 0.25rem 0.25rem 0;
     800    }
     801}
     802
    799803@media screen and (max-width: 480px) {
    800804    div.widget-liquid-left {
  • trunk/src/wp-includes/widgets.php

    r48197 r48389  
    16431643    ?>
    16441644    </select></p>
    1645 <?php endif; if ( $inputs['show_summary'] ) : ?>
    1646     <p><input id="rss-show-summary-<?php echo $esc_number; ?>" name="widget-rss[<?php echo $esc_number; ?>][show_summary]" type="checkbox" value="1" <?php checked( $args['show_summary'] ); ?> />
    1647     <label for="rss-show-summary-<?php echo $esc_number; ?>"><?php _e( 'Display item content?' ); ?></label></p>
    1648 <?php endif; if ( $inputs['show_author'] ) : ?>
    1649     <p><input id="rss-show-author-<?php echo $esc_number; ?>" name="widget-rss[<?php echo $esc_number; ?>][show_author]" type="checkbox" value="1" <?php checked( $args['show_author'] ); ?> />
    1650     <label for="rss-show-author-<?php echo $esc_number; ?>"><?php _e( 'Display item author if available?' ); ?></label></p>
    1651 <?php endif; if ( $inputs['show_date'] ) : ?>
    1652     <p><input id="rss-show-date-<?php echo $esc_number; ?>" name="widget-rss[<?php echo $esc_number; ?>][show_date]" type="checkbox" value="1" <?php checked( $args['show_date'] ); ?>/>
    1653     <label for="rss-show-date-<?php echo $esc_number; ?>"><?php _e( 'Display item date?' ); ?></label></p>
     1645<?php endif; if ( $inputs['show_summary'] || $inputs['show_author'] || $inputs['show_date'] ) : ?>
     1646    <p>
     1647    <?php if ( $inputs['show_summary'] ) : ?>
     1648        <input id="rss-show-summary-<?php echo $esc_number; ?>" name="widget-rss[<?php echo $esc_number; ?>][show_summary]" type="checkbox" value="1" <?php checked( $args['show_summary'] ); ?> />
     1649        <label for="rss-show-summary-<?php echo $esc_number; ?>"><?php _e( 'Display item content?' ); ?></label><br />
     1650    <?php endif; if ( $inputs['show_author'] ) : ?>
     1651        <input id="rss-show-author-<?php echo $esc_number; ?>" name="widget-rss[<?php echo $esc_number; ?>][show_author]" type="checkbox" value="1" <?php checked( $args['show_author'] ); ?> />
     1652        <label for="rss-show-author-<?php echo $esc_number; ?>"><?php _e( 'Display item author if available?' ); ?></label><br />
     1653    <?php endif; if ( $inputs['show_date'] ) : ?>
     1654        <input id="rss-show-date-<?php echo $esc_number; ?>" name="widget-rss[<?php echo $esc_number; ?>][show_date]" type="checkbox" value="1" <?php checked( $args['show_date'] ); ?>/>
     1655        <label for="rss-show-date-<?php echo $esc_number; ?>"><?php _e( 'Display item date?' ); ?></label><br />
     1656    <?php endif; ?>
     1657    </p>
    16541658    <?php
    1655     endif;
     1659    endif; // end of display options
    16561660foreach ( array_keys( $default_inputs ) as $input ) :
    16571661    if ( 'hidden' === $inputs[ $input ] ) :
Note: See TracChangeset for help on using the changeset viewer.