Changeset 48392

Timestamp:

07/07/2020 06:13:14 PM (4 years ago)

Author:

ocean90

Message:

I18N: Use wp.i18n for translatable strings in wp-admin/js/plugin-install.js.

This removes the usage of wp_localize_script() for passing translations to the script and instead adds the translatable strings in the script directly through the use of wp.i18n and its utilities.

Props swissspidy, ocean90.
See #20491.
Fixes #50602.

Location:

trunk/src

Files:

• js/_enqueues/admin/plugin-install.js (modified) (3 diffs)
• wp-includes/script-loader.php (modified) (1 diff)

trunk/src/js/_enqueues/admin/plugin-install.js

@@ -5 +5 @@
  */
 
-/* global plugininstallL10n, tb_click, tb_remove, tb_position */
+/* global tb_click, tb_remove, tb_position */
 
 jQuery( document ).ready( function( $ ) {
@@ -157 +157 @@
     $( '.wrap' ).on( 'click', '.thickbox.open-plugin-details-modal', function( e ) {
         // The `data-title` attribute is used only in the Plugin screens.
-        var title = $( this ).data( 'title' ) ? plugininstallL10n.plugin_information + ' ' + $( this ).data( 'title' ) : plugininstallL10n.plugin_modal_label;
+        var title = $( this ).data( 'title' ) ?
+            wp.i18n.sprintf(
+                // translators: %s: Plugin name.
+                wp.i18n.__( 'Plugin: %s' ),
+                $( this ).data( 'title' )
+            ) :
+            wp.i18n.__( 'Plugin details' );
 
         e.preventDefault();
@@ -171 +177 @@
             .attr({
                 'role': 'dialog',
-                'aria-label': plugininstallL10n.plugin_modal_label
+                'aria-label': wp.i18n.__( 'Plugin details' )
             })
             .addClass( 'plugin-details-modal' );

trunk/src/wp-includes/script-loader.php

@@ -1261 +1261 @@
 
         $scripts->add( 'plugin-install', "/wp-admin/js/plugin-install$suffix.js", array( 'jquery', 'jquery-ui-core', 'thickbox' ), false, 1 );
-        did_action( 'init' ) && $scripts->localize(
-            'plugin-install',
-            'plugininstallL10n',
-            array(
-                'plugin_information' => __( 'Plugin:' ),
-                'plugin_modal_label' => __( 'Plugin details' ),
-                'ays'                => __( 'Are you sure you want to install this plugin?' ),
-            )
-        );
+        $scripts->set_translations( 'plugin-install' );
 
         $scripts->add( 'site-health', "/wp-admin/js/site-health$suffix.js", array( 'clipboard', 'jquery', 'wp-util', 'wp-a11y' ), false, 1 );