Changeset 48396

Timestamp:

07/07/2020 06:53:50 PM (6 years ago)

Author:

ocean90

Message:

I18N: Use wp.i18n for translatable strings in wp-admin/js/set-post-thumbnail.js.

This removes the usage of wp_localize_script() for passing translations to the script and instead adds the translatable strings in the script directly through the use of wp.i18n and its utilities.

Props swissspidy, ocean90.
See #20491.
Fixes #50605.

Location:

trunk/src

Files:

• js/_enqueues/admin/post.js (modified) (2 diffs)
• js/_enqueues/admin/set-post-thumbnail.js (modified) (2 diffs)
• js/_enqueues/wp/media/editor.js (modified) (1 diff)
• wp-includes/script-loader.php (modified) (2 diffs)

trunk/src/js/_enqueues/admin/post.js

@@ -5 +5 @@
  */
 
- /* global ajaxurl, wpAjax, setPostThumbnailL10n, postboxes, pagenow, tinymce, alert, deleteUserSetting, ClipboardJS */
+ /* global ajaxurl, wpAjax, postboxes, pagenow, tinymce, alert, deleteUserSetting, ClipboardJS */
  /* global theList:true, theExtraList:true, getUserSetting, setUserSetting, commentReply, commentsBox */
  /* global WPSetThumbnailHTML, wptitlehint */
@@ -146 +146 @@
                         function(str){
                         if ( str == '0' ) {
-                                alert( setPostThumbnailL10n.error );
+                                alert( __( 'Could not set that as the thumbnail image. Try a different attachment.' ) );
                         } else {
                                 WPSetThumbnailHTML(str);

trunk/src/js/_enqueues/admin/set-post-thumbnail.js

@@ -3 +3 @@
  */
 
-/* global setPostThumbnailL10n, ajaxurl, post_id, alert */
+/* global ajaxurl, post_id, alert */
 /* exported WPSetAsThumbnail */
 
@@ -9 +9 @@
         var $link = jQuery('a#wp-post-thumbnail-' + id);
 
-        $link.text( setPostThumbnailL10n.saving );
+        $link.text( wp.i18n.__( 'Saving…' ) );
         jQuery.post(ajaxurl, {
                 action: 'set-post-thumbnail', post_id: post_id, thumbnail_id: id, _ajax_nonce: nonce, cookie: encodeURIComponent( document.cookie )
         }, function(str){
                 var win = window.dialogArguments || opener || parent || top;
-                $link.text( setPostThumbnailL10n.setThumbnail );
+                $link.text( wp.i18n.__( 'Use as featured image' ) );
                 if ( str == '0' ) {
-                        alert( setPostThumbnailL10n.error );
+                        alert( wp.i18n.__( 'Could not set that as the thumbnail image. Try a different attachment.' ) );
                 } else {
                         jQuery('a.wp-post-thumbnail').show();
-                        $link.text( setPostThumbnailL10n.done );
+                        $link.text( wp.i18n.__( 'Done' ) );
                         $link.fadeOut( 2000 );
                         win.WPSetThumbnailID(id);

trunk/src/js/_enqueues/wp/media/editor.js

@@ -628 +628 @@
                         }).done( function( html ) {
                                 if ( '0' === html ) {
-                                        window.alert( window.setPostThumbnailL10n.error );
+                                        window.alert( wp.i18n.__( 'Could not set that as the thumbnail image. Try a different attachment.' ) );
                                         return;
                                 }

trunk/src/wp-includes/script-loader.php

@@ -1187 +1187 @@
 
         $scripts->add( 'media-editor', "/wp-includes/js/media-editor$suffix.js", array( 'shortcode', 'media-views' ), false, 1 );
+        $scripts->set_translations( 'media-editor' );
         $scripts->add( 'media-audiovideo', "/wp-includes/js/media-audiovideo$suffix.js", array( 'media-editor' ), false, 1 );
         $scripts->add( 'mce-view', "/wp-includes/js/mce-view$suffix.js", array( 'shortcode', 'jquery', 'media-views', 'media-audiovideo' ), false, 1 );
@@ -1288 +1289 @@
 
                 $scripts->add( 'set-post-thumbnail', "/wp-admin/js/set-post-thumbnail$suffix.js", array( 'jquery' ), false, 1 );
-                did_action( 'init' ) && $scripts->localize(
-                        'set-post-thumbnail',
-                        'setPostThumbnailL10n',
-                        array(
-                                'setThumbnail' => __( 'Use as featured image' ),
-                                'saving'       => __( 'Saving...' ), // No ellipsis.
-                                'error'        => __( 'Could not set that as the thumbnail image. Try a different attachment.' ),
-                                'done'         => __( 'Done' ),
-                        )
-                );
+                $scripts->set_translations( 'set-post-thumbnail' );
 
                 /*