Changeset 48396 for trunk/src/wp-includes/script-loader.php

Timestamp:

07/07/2020 06:53:50 PM (6 years ago)

Author:

ocean90

Message:

I18N: Use wp.i18n for translatable strings in wp-admin/js/set-post-thumbnail.js.

This removes the usage of wp_localize_script() for passing translations to the script and instead adds the translatable strings in the script directly through the use of wp.i18n and its utilities.

Props swissspidy, ocean90.
See #20491.
Fixes #50605.

File:

• trunk/src/wp-includes/script-loader.php (modified) (2 diffs)

trunk/src/wp-includes/script-loader.php

@@ -1187 +1187 @@
 
     $scripts->add( 'media-editor', "/wp-includes/js/media-editor$suffix.js", array( 'shortcode', 'media-views' ), false, 1 );
+    $scripts->set_translations( 'media-editor' );
     $scripts->add( 'media-audiovideo', "/wp-includes/js/media-audiovideo$suffix.js", array( 'media-editor' ), false, 1 );
     $scripts->add( 'mce-view', "/wp-includes/js/mce-view$suffix.js", array( 'shortcode', 'jquery', 'media-views', 'media-audiovideo' ), false, 1 );
@@ -1288 +1289 @@
 
         $scripts->add( 'set-post-thumbnail', "/wp-admin/js/set-post-thumbnail$suffix.js", array( 'jquery' ), false, 1 );
-        did_action( 'init' ) && $scripts->localize(
-            'set-post-thumbnail',
-            'setPostThumbnailL10n',
-            array(
-                'setThumbnail' => __( 'Use as featured image' ),
-                'saving'       => __( 'Saving...' ), // No ellipsis.
-                'error'        => __( 'Could not set that as the thumbnail image. Try a different attachment.' ),
-                'done'         => __( 'Done' ),
-            )
-        );
+        $scripts->set_translations( 'set-post-thumbnail' );
 
         /*