Changeset 48418 for trunk/src/wp-admin/themes.php

Timestamp:

07/10/2020 06:16:06 AM (6 years ago)

Author:

whyisjake

Message:

Upgrade/Install: Use ARIA button class on plugin and theme auto-updates action links

According to the [accesability guidelines](​https://developer.wordpress.org/coding-standards/wordpress-coding-standards/accessibility/#semantics-for-controls), the control should be a link when JavaScript is not available and a button the rest of the time.

In addition, handlers were added for spacebar usage, and some changes to the a11y speak verbiage.

Fixes #50516.
Props ryokuhi, audrasjb, afercia, whyisjake/

File:

• trunk/src/wp-admin/themes.php (modified) (1 diff)

trunk/src/wp-admin/themes.php

@@ -563 +563 @@
         <div class="theme-autoupdate">
             <# if ( data.autoupdate ) { #>
-                <a href="{{{ data.actions.autoupdate }}}" class="toggle-auto-update" data-slug="{{ data.id }}" data-wp-action="disable">
-                    <span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>
-                    <span class="label">' . __( 'Disable auto-updates' ) . '</span>
-                </a>
+                <button type="button" class="toggle-auto-update button-link" data-slug="{{ data.id }}" data-wp-action="disable">
+                    <span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span><span class="label">' . __( 'Disable auto-updates' ) . '</span>
+                </button>
             <# } else { #>
-                <a href="{{{ data.actions.autoupdate }}}" class="toggle-auto-update" data-slug="{{ data.id }}" data-wp-action="enable">
-                    <span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>
-                    <span class="label">' . __( 'Enable auto-updates' ) . '</span>
+                <button type="button" class="toggle-auto-update button-link" data-slug="{{ data.id }}" data-wp-action="enable">
+                    <span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span><span class="label">' . __( 'Enable auto-updates' ) . '</span>
                 </a>
             <# } #>