Changeset 48422 for trunk/src/wp-includes/revision.php

Timestamp:

07/10/2020 03:12:00 PM (6 years ago)

Author:

adamsilverstein

Message:

Revisions: optimize performance when post has large number of revisions.

Improve speed and reduce the memory footprint when loading posts with many revisions.

• Use a direct query in wp_get_post_autosave to avoid loading all revisions.
• Query for IDs vs full objects in register_and_do_post_meta_boxes.

Props pdfernhout, johnnyb, miqrogroove, ocean90, senatorman, DBrumbaugh10Up, martijn-van-der-kooij, pavelevap, mackensen, mikeyarce, whyisjake.
Fixes #34560.

File:

• trunk/src/wp-includes/revision.php (modified) (2 diffs)

trunk/src/wp-includes/revision.php

@@ -222 +222 @@
  * Retrieve the autosaved data of the specified post.
  *
- * Returns a post object containing the information that was autosaved for the
+ * Returns an object containing the information that was autosaved for the
  * specified post. If the optional $user_id is passed, returns the autosave for that user
  * otherwise returns the latest autosave.
@@ -233 +233 @@
  */
 function wp_get_post_autosave( $post_id, $user_id = 0 ) {
-        $revisions = wp_get_post_revisions( $post_id, array( 'check_enabled' => false ) );
-
-        foreach ( $revisions as $revision ) {
-                if ( false !== strpos( $revision->post_name, "{$post_id}-autosave" ) ) {
-                        if ( $user_id && $user_id != $revision->post_author ) {
-                                continue;
-                        }
-
-                        return $revision;
-                }
-        }
-
-        return false;
+        global $wpdb;
+
+        $autosave_name = $post_id . '-autosave-v1';
+        $user_id_query = ( 0 !== $user_id ) ? "AND post_author = $user_id" : null;
+
+        // Construct the autosave query
+        $autosave_query = "
+                SELECT *
+                FROM $wpdb->posts
+                WHERE post_parent = %d
+                AND post_type = 'revision'
+                AND post_status = 'inherit'
+                AND post_name   = %s " . $user_id_query . '
+                ORDER BY post_date DESC
+                LIMIT 1';
+
+        $autosave = $wpdb->get_results(
+                $wpdb->prepare(
+                        $autosave_query,
+                        $post_id,
+                        $autosave_name
+                )
+        );
+
+        if ( ! $autosave ) {
+                return false;
+        }
+
+        return $autosave[0];
 }