Changeset 48423 for trunk/src/wp-admin/includes/class-wp-screen.php

Timestamp:

07/10/2020 04:00:42 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Administration: Make some adjustments to WP_Screen::render_view_mode():

• Restore the $mode global for backward compatibility.
• Remove redundant check, as $mode is already set at this point, and already defaults to list via get_user_setting()'s second argument.
• Use sentence case for "View mode" and "Extended view" labels.

Follow-up to [48398].

See #49715.

File:

• trunk/src/wp-admin/includes/class-wp-screen.php (modified) (5 diffs)

trunk/src/wp-admin/includes/class-wp-screen.php

@@ -1287 +1287 @@
      */
     public function render_view_mode() {
+        global $mode;
+
         $screen = get_current_screen();
 
@@ -1312 +1314 @@
         $mode = get_user_setting( 'posts_list_mode', 'list' );
 
-        // Set 'list' as default value if $mode is not set.
-        $mode = ( isset( $mode ) && 'extended' === $mode ) ? 'extended' : 'list';
-
         /**
          * Filters the current view mode.
@@ -1320 +1319 @@
          * @since 5.5.0
          *
-         * @param string $mode The current selected mode. Default value of
-         *                     posts_list_mode user setting.
+         * @param string $mode The current selected mode. Defaults to the value
+         *                     of 'posts_list_mode' user setting.
          */
         $mode = apply_filters( 'table_view_mode', $mode );
@@ -1329 +1328 @@
         ?>
         <fieldset class="metabox-prefs view-mode">
-        <legend><?php _e( 'View Mode' ); ?></legend>
+        <legend><?php _e( 'View mode' ); ?></legend>
                 <label for="list-view-mode">
                     <input id="list-view-mode" type="radio" name="mode" value="list" <?php checked( 'list', $mode ); ?> />
@@ -1336 +1335 @@
                 <label for="excerpt-view-mode">
                     <input id="excerpt-view-mode" type="radio" name="mode" value="extended" <?php checked( 'extended', $mode ); ?> />
-                    <?php _e( 'Extended View' ); ?>
+                    <?php _e( 'Extended view' ); ?>
                 </label>
                 <?php