Changeset 48435 for trunk/src/wp-includes/feed.php

Timestamp:

07/11/2020 12:12:46 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() in wp-includes/feed.php.

Additionally:

• Correct inline comments per the documentation standards.
• Correct the @ticket reference in tests/feed/atom.php.

Follow-up to [48429].

See #33591.

File:

• trunk/src/wp-includes/feed.php (modified) (2 diffs)

trunk/src/wp-includes/feed.php

@@ -527 +527 @@
                                 $mimes = get_allowed_mime_types();
 
-                                // Parse url
+                                // Parse URL.
                                 if ( isset( $enclosure[0] ) && is_string( $enclosure[0] ) ) {
                                         $url = trim( $enclosure[0] );
                                 }
 
-                                // Parse length and type
-                                foreach ( range( 1, 2 ) as $i ) {
+                                // Parse length and type.
+                                for ( $i = 1; $i <= 2; $i++ ) {
                                         if ( isset( $enclosure[ $i ] ) ) {
                                                 if ( is_numeric( $enclosure[ $i ] ) ) {
                                                         $length = trim( $enclosure[ $i ] );
-                                                } elseif ( in_array( $enclosure[ $i ], $mimes ) ) {
+                                                } elseif ( in_array( $enclosure[ $i ], $mimes, true ) ) {
                                                         $type = trim( $enclosure[ $i ] );
                                                 }
@@ -549 +549 @@
                                         esc_attr( $type )
                                 );
+
                                 /**
                                  * Filters the atom enclosure HTML link tag for the current post.