Changeset 48436

Timestamp:

07/11/2020 12:28:07 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Revisions: Replace array_shift() with reset() in register_and_do_post_meta_boxes() for better performance.

Follow-up to [31829], [48422].

See #34560.

File:

• trunk/src/wp-admin/includes/meta-boxes.php (modified) (2 diffs)

trunk/src/wp-admin/includes/meta-boxes.php

@@ -1437 +1437 @@
 
     $publish_callback_args = array( '__back_compat_meta_box' => true );
+
     if ( post_type_supports( $post_type, 'revisions' ) && 'auto-draft' !== $post->post_status ) {
         $revisions = wp_get_post_revisions( $post->ID, array( 'fields' => 'ids' ) );
@@ -1442 +1443 @@
         // We should aim to show the revisions meta box only when there are revisions.
         if ( count( $revisions ) > 1 ) {
-            reset( $revisions ); // Reset pointer for key().
             $publish_callback_args = array(
                 'revisions_count'        => count( $revisions ),
-                'revision_id'            => array_shift( $revisions ),
+                'revision_id'            => reset( $revisions ),
                 '__back_compat_meta_box' => true,
             );
+
             add_meta_box( 'revisionsdiv', __( 'Revisions' ), 'post_revisions_meta_box', null, 'normal', 'core', array( '__back_compat_meta_box' => true ) );
         }