Changeset 48438

Timestamp:

07/11/2020 09:13:56 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Revisions: Restore the return value of wp_get_post_autosave() to the documented type of WP_Post for backward compatibility.

Follow-up to [48422].

See #34560.

Location:

trunk

Files:

• src/wp-includes/revision.php (modified) (3 diffs)
• tests/phpunit/tests/ajax/CustomizeManager.php (modified) (2 diffs)
• tests/phpunit/tests/customize/manager.php (modified) (1 diff)

trunk/src/wp-includes/revision.php

@@ -222 +222 @@
  * Retrieve the autosaved data of the specified post.
  *
- * Returns an object containing the information that was autosaved for the
- * specified post. If the optional $user_id is passed, returns the autosave for that user
- * otherwise returns the latest autosave.
+ * Returns a post object with the information that was autosaved for the specified post.
+ * If the optional $user_id is passed, returns the autosave for that user, otherwise
+ * returns the latest autosave.
  *
  * @since 2.6.0
@@ -238 +238 @@
     $user_id_query = ( 0 !== $user_id ) ? "AND post_author = $user_id" : null;
 
-    // Construct the autosave query
+    // Construct the autosave query.
     $autosave_query = "
         SELECT *
@@ -261 +261 @@
     }
 
-    return $autosave[0];
+    return get_post( $autosave[0] );
 }
 

trunk/tests/phpunit/tests/ajax/CustomizeManager.php

@@ -473 +473 @@
         $this->assertEquals( 'draft', $this->_last_response_parsed['data']['changeset_status'] );
         $autosave_revision = wp_get_post_autosave( $post_id );
-        $this->assertInstanceOf( 'stdClass', $autosave_revision );
+        $this->assertInstanceOf( 'WP_Post', $autosave_revision );
 
         $this->assertContains( 'New Site Title', get_post( $post_id )->post_content );
@@ -700 +700 @@
         $this->assertNotWPError( $r );
         $autosave_revision = wp_get_post_autosave( $wp_customize->changeset_post_id() );
-        $this->assertInstanceOf( 'stdClass', $autosave_revision );
+        $this->assertInstanceOf( 'WP_Post', $autosave_revision );
         $this->assertContains( 'Foo', get_post( $wp_customize->changeset_post_id() )->post_content );
         $this->assertContains( 'Bar', $autosave_revision->post_content );

trunk/tests/phpunit/tests/customize/manager.php

@@ -1892 +1892 @@
         // Verify that autosave happened.
         $autosave_revision = wp_get_post_autosave( $changeset_post_id, get_current_user_id() );
-        $this->assertInstanceOf( 'stdClass', $autosave_revision );
+        $this->assertInstanceOf( 'WP_Post', $autosave_revision );
         $this->assertContains( 'Draft Title', get_post( $changeset_post_id )->post_content );
         $this->assertContains( 'Autosave Title', $autosave_revision->post_content );