Changeset 48451

Timestamp:

07/12/2020 01:20:58 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Plugins: Make delete plugin message less scary.

This adds a check if the plugin actually has an uninstall routine before saying that its data will be deleted too.

Props samful, joostdevalk, joyously, Chouby, SergeyBiryukov.
Fixes #50346.

Location:

trunk/src

Files:

• js/_enqueues/wp/updates.js (modified) (2 diffs)
• wp-admin/includes/class-wp-plugins-list-table.php (modified) (1 diff)

trunk/src/js/_enqueues/wp/updates.js

@@ -2139 +2139 @@
         $bulkActionForm.on( 'click', '[data-plugin] a.delete', function( event ) {
             var $pluginRow = $( event.target ).parents( 'tr' ),
+                confirmMessage;
+
+            if ( $pluginRow.hasClass( 'is-uninstallable' ) ) {
                 confirmMessage = sprintf(
                     /* translators: %s: Plugin name. */
@@ -2144 +2147 @@
                     $pluginRow.find( '.plugin-title strong' ).text()
                 );
+            } else {
+                confirmMessage = sprintf(
+                    /* translators: %s: Plugin name. */
+                    __( 'Are you sure you want to delete %s?' ),
+                    $pluginRow.find( '.plugin-title strong' ).text()
+                );
+            }
 
             event.preventDefault();

trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

@@ -943 +943 @@
         }
 
+        if ( is_uninstallable_plugin( $plugin_file ) ) {
+            $class .= ' is-uninstallable';
+        }
+
         printf(
             '<tr class="%s" data-slug="%s" data-plugin="%s">',