Changeset 48455 for trunk/src/wp-admin/includes/class-plugin-installer-skin.php

Timestamp:

07/13/2020 01:33:32 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Upgrade/Install: Simplify compatibility checks for uploaded plugins and themes for better readability.

Use $new_plugin_data and $new_theme_data as a shorthand for the corresponding $this->upgrader properties.

Follow-up to [48390], [48448].

Props afragen.
See #9757.

File:

• trunk/src/wp-admin/includes/class-plugin-installer-skin.php (modified) (8 diffs)

trunk/src/wp-admin/includes/class-plugin-installer-skin.php

@@ -187 +187 @@
 
         $current_plugin_data = false;
-        foreach ( get_plugins() as $plugin => $plugin_data ) {
+        $all_plugins         = get_plugins();
+
+        foreach ( $all_plugins as $plugin => $plugin_data ) {
             if ( strrpos( $plugin, $folder ) !== 0 ) {
                 continue;
@@ -195 +197 @@
         }
 
-        if ( empty( $current_plugin_data ) || empty( $this->upgrader->new_plugin_data ) ) {
+        $new_plugin_data = $this->upgrader->new_plugin_data;
+
+        if ( ! $current_plugin_data || ! $new_plugin_data ) {
             return false;
         }
@@ -201 +205 @@
         echo '<h2 class="update-from-upload-heading">' . esc_html( __( 'This plugin is already installed.' ) ) . '</h2>';
 
-        $this->is_downgrading = version_compare( $current_plugin_data['Version'], $this->upgrader->new_plugin_data['Version'], '>' );
+        $this->is_downgrading = version_compare( $current_plugin_data['Version'], $new_plugin_data['Version'], '>' );
 
         $rows = array(
@@ -219 +223 @@
         foreach ( $rows as $field => $label ) {
             $old_value = ! empty( $current_plugin_data[ $field ] ) ? (string) $current_plugin_data[ $field ] : '-';
-            $new_value = ! empty( $this->upgrader->new_plugin_data[ $field ] ) ? (string) $this->upgrader->new_plugin_data[ $field ] : '-';
+            $new_value = ! empty( $new_plugin_data[ $field ] ) ? (string) $new_plugin_data[ $field ] : '-';
 
             $is_same_plugin = $is_same_plugin && ( $old_value === $new_value );
@@ -242 +246 @@
          * @param array  $new_plugin_data     Array with uploaded plugin data.
          */
-        echo apply_filters( 'install_plugin_ovewrite_comparison', $table, $current_plugin_data, $this->upgrader->new_plugin_data );
+        echo apply_filters( 'install_plugin_ovewrite_comparison', $table, $current_plugin_data, $new_plugin_data );
 
         $install_actions = array();
@@ -250 +254 @@
         $blocked_message .= '<ul class="ul-disc">';
 
-        if ( ! empty( $this->upgrader->new_plugin_data['RequiresPHP'] )
-            && ! is_php_version_compatible( $this->upgrader->new_plugin_data['RequiresPHP'] )
-        ) {
+        $requires_php = isset( $new_plugin_data['RequiresPHP'] ) ? $new_plugin_data['RequiresPHP'] : null;
+        $requires_wp  = isset( $new_plugin_data['RequiresWP'] ) ? $new_plugin_data['RequiresWP'] : null;
+
+        if ( ! is_php_version_compatible( $requires_php ) ) {
             $error = sprintf(
                 /* translators: 1: Current PHP version, 2: Version required by the uploaded plugin. */
                 __( 'The PHP version on your server is %1$s, however the uploaded plugin requires %2$s.' ),
                 phpversion(),
-                $this->upgrader->new_plugin_data['RequiresPHP']
+                $requires_php
             );
 
@@ -264 +269 @@
         }
 
-        if ( ! empty( $this->upgrader->new_plugin_data['RequiresWP'] )
-            && ! is_wp_version_compatible( $this->upgrader->new_plugin_data['RequiresWP'] )
-        ) {
+        if ( ! is_wp_version_compatible( $requires_wp ) ) {
             $error = sprintf(
                 /* translators: 1: Current WordPress version, 2: Version required by the uploaded plugin. */
                 __( 'Your WordPress version is %1$s, however the uploaded plugin requires %2$s.' ),
-                $GLOBALS['wp_version'],
-                $this->upgrader->new_plugin_data['RequiresWP']
+                get_bloginfo( 'version' ),
+                $requires_wp
             );
 
@@ -325 +328 @@
          * @param array    $new_plugin_data Array with uploaded plugin data.
          */
-        $install_actions = apply_filters( 'install_plugin_ovewrite_actions', $install_actions, $this->api, $this->upgrader->new_plugin_data );
+        $install_actions = apply_filters( 'install_plugin_ovewrite_actions', $install_actions, $this->api, $new_plugin_data );
 
         if ( ! empty( $install_actions ) ) {