Changeset 48476

Timestamp:

07/14/2020 12:24:02 PM (4 years ago)

Author:

swissspidy

Message:

Sitemaps: Ensure entry for ‘page’ post type sitemap in index.

If there are no pages and no static homepage, there will still be one sitemap including the homepage URL.

This change ensures that this sitemap is correctly listed in the sitemap index.

Props Chouby, pacifika, elrae.
Fixes #50571.

Location:

trunk

Files:

• src/wp-includes/sitemaps/providers/class-wp-sitemaps-posts.php (modified) (1 diff)
• tests/phpunit/tests/sitemaps/sitemaps-posts.php (modified) (1 diff)

trunk/src/wp-includes/sitemaps/providers/class-wp-sitemaps-posts.php

@@ -175 +175 @@
         $query = new WP_Query( $args );
 
-        return isset( $query->max_num_pages ) ? $query->max_num_pages : 1;
+        $min_num_pages = ( 'page' === $post_type && 'posts' === get_option( 'show_on_front' ) ) ? 1 : 0;
+        return isset( $query->max_num_pages ) ? max( $min_num_pages, $query->max_num_pages ) : 1;
     }
 

trunk/tests/phpunit/tests/sitemaps/sitemaps-posts.php

@@ -5 +5 @@
  */
 class Test_WP_Sitemaps_Posts extends WP_UnitTestCase {
+    /**
+     * Tests getting sitemap entries for post type page with 'posts' homepage.
+     *
+     * Ensures that an entry is added even if there are no pages.
+     *
+     * @ticket 50571
+     */
+    public function test_get_sitemap_entries_homepage() {
+        update_option( 'show_on_front', 'posts' );
+
+        $posts_provider = new WP_Sitemaps_Posts();
+
+        $post_list = $posts_provider->get_sitemap_entries();
+
+        $expected = array(
+            array(
+                'loc' => home_url( '/?sitemap=posts&sitemap-subtype=page&paged=1' ),
+            ),
+        );
+
+        $this->assertEquals( $expected, $post_list );
+    }
+
     /**
      * Test ability to filter object subtypes.