Changeset 48479

Timestamp:

07/14/2020 03:44:16 PM (5 years ago)

Author:

afercia

Message:

Accessibility: Security: Improves the accessible audible messages for Plugins & Themes Auto-Updates.

• changes the politeness level of the two error messages introduced in [47835] to assertive
• remove unnecessary polite parameters as that's the default value

See #50512, #50052.

File:

• trunk/src/js/_enqueues/wp/updates.js (modified) (18 diffs)

trunk/src/js/_enqueues/wp/updates.js

@@ -454 +454 @@
             .text( _x( 'Updated!', 'plugin' ) );
 
-        wp.a11y.speak( __( 'Update completed successfully.' ), 'polite' );
+        wp.a11y.speak( __( 'Update completed successfully.' ) );
 
         wp.updates.decrementCount( 'plugin' );
@@ -599 +599 @@
             .text( __( 'Installing...' ) );
 
-        wp.a11y.speak( __( 'Installing... please wait.' ), 'polite' );
+        wp.a11y.speak( __( 'Installing... please wait.' ) );
 
         // Remove previous error messages, if any.
@@ -635 +635 @@
             .text( _x( 'Installed!', 'plugin' ) );
 
-        wp.a11y.speak( __( 'Installation completed successfully.' ), 'polite' );
+        wp.a11y.speak( __( 'Installation completed successfully.' ) );
 
         $document.trigger( 'wp-plugin-install-success', response );
@@ -769 +769 @@
             .text( __( 'Run Importer' ) );
 
-        wp.a11y.speak( __( 'Installation completed successfully.' ), 'polite' );
+        wp.a11y.speak( __( 'Installation completed successfully.' ) );
 
         $document.trigger( 'wp-importer-install-success', response );
@@ -852 +852 @@
         }
 
-        wp.a11y.speak( __( 'Deleting...' ), 'polite' );
+        wp.a11y.speak( __( 'Deleting...' ) );
 
         $document.trigger( 'wp-plugin-deleting', args );
@@ -947 +947 @@
         } );
 
-        wp.a11y.speak( _x( 'Deleted!', 'plugin' ), 'polite' );
+        wp.a11y.speak( _x( 'Deleted!', 'plugin' ) );
 
         $document.trigger( 'wp-plugin-delete-success', response );
@@ -1056 +1056 @@
         }
 
-        wp.a11y.speak( __( 'Updating... please wait.' ), 'polite' );
+        wp.a11y.speak( __( 'Updating... please wait.' ) );
         $notice.text( __( 'Updating...' ) );
 
@@ -1118 +1118 @@
 
         wp.updates.addAdminNotice( _.extend( { selector: $notice }, updatedMessage ) );
-        wp.a11y.speak( __( 'Update completed successfully.' ), 'polite' );
+        wp.a11y.speak( __( 'Update completed successfully.' ) );
 
         wp.updates.decrementCount( 'theme' );
@@ -1175 +1175 @@
         } );
 
-        wp.a11y.speak( errorMessage, 'polite' );
+        wp.a11y.speak( errorMessage );
 
         $document.trigger( 'wp-theme-update-error', response );
@@ -1217 +1217 @@
             .text( __( 'Installing...' ) );
 
-        wp.a11y.speak( __( 'Installing... please wait.' ), 'polite' );
+        wp.a11y.speak( __( 'Installing... please wait.' ) );
 
         // Remove previous error messages, if any.
@@ -1256 +1256 @@
             .text( _x( 'Installed!', 'theme' ) );
 
-        wp.a11y.speak( __( 'Installation completed successfully.' ), 'polite' );
+        wp.a11y.speak( __( 'Installation completed successfully.' ) );
 
         setTimeout( function() {
@@ -1404 +1404 @@
         }
 
-        wp.a11y.speak( __( 'Deleting...' ), 'polite' );
+        wp.a11y.speak( __( 'Deleting...' ) );
 
         // Remove previous error messages, if any.
@@ -1467 +1467 @@
         }
 
-        wp.a11y.speak( _x( 'Deleted!', 'theme' ), 'polite' );
+        wp.a11y.speak( _x( 'Deleted!', 'theme' ) );
 
         $document.trigger( 'wp-theme-delete-success', response );
@@ -1997 +1997 @@
             }
 
-            wp.a11y.speak( __( 'Update canceled.' ), 'polite' );
+            wp.a11y.speak( __( 'Update canceled.' ) );
         } );
 
@@ -2075 +2075 @@
                         .text( __( 'Install Now' ) );
 
-                    wp.a11y.speak( __( 'Update canceled.' ), 'polite' );
+                    wp.a11y.speak( __( 'Update canceled.' ) );
                 } );
             }
@@ -2118 +2118 @@
                         .text( __( 'Install Now' ) );
 
-                    wp.a11y.speak( __( 'Update canceled.' ), 'polite' );
+                    wp.a11y.speak( __( 'Update canceled.' ) );
                 } );
             }
@@ -2783 +2783 @@
 
                         $parent.find( '.notice.notice-error' ).removeClass( 'hidden' ).find( 'p' ).text( errorMessage );
-                        wp.a11y.speak( errorMessage, 'polite' );
+                        wp.a11y.speak( errorMessage, 'assertive' );
                         return;
                     }
@@ -2845 +2845 @@
                         .text( __( 'The request could not be completed.' ) );
 
-                    wp.a11y.speak( __( 'The request could not be completed.' ), 'polite' );
+                    wp.a11y.speak( __( 'The request could not be completed.' ), 'assertive' );
                 } )
                 .always( function() {