Changeset 48480

Timestamp:

07/14/2020 04:39:44 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Taxonomy: Make some adjustments to handling default terms for custom taxonomies:

• Move default term assignment from wp_set_object_terms() to wp_insert_post().
• Make sure the passed taxonomy list overwrites the existing list if not empty.
• Remove the default term option on unregister_taxonomy().
• Prevent deletion of the default term in wp_delete_term().

Props enrico.sorcinelli, TimothyBlynJacobs.
See #43517.

Location:

trunk

Files:

• src/wp-includes/post.php (modified) (1 diff)
• src/wp-includes/taxonomy.php (modified) (3 diffs)
• tests/phpunit/tests/taxonomy.php (modified) (2 diffs)

trunk/src/wp-includes/post.php

@@ -4037 +4037 @@
         if ( 'auto-draft' !== $post_status ) {
                 foreach ( get_object_taxonomies( $post_type, 'object' ) as $taxonomy => $tax_object ) {
-                        if ( ! empty( $tax_object->default_term ) && ( empty( $postarr['tax_input'] ) || ! isset( $postarr['tax_input'][ $taxonomy ] ) ) ) {
-                                $postarr['tax_input'][ $taxonomy ] = array();
+
+                        if ( ! empty( $tax_object->default_term ) ) {
+
+                                // Filter out empty terms.
+                                if ( isset( $postarr['tax_input'] ) && is_array( $postarr['tax_input'][ $taxonomy ] ) ) {
+                                        $postarr['tax_input'][ $taxonomy ] = array_filter( $postarr['tax_input'][ $taxonomy ] );
+                                }
+
+                                // Passed custom taxonomy list overwrites existing list if not empty.
+                                $terms = wp_get_object_terms( $post_ID, $taxonomy, array( 'fields' => 'ids' ) );
+                                if ( ! empty( $terms ) && empty( $postarr['tax_input'][ $taxonomy ] ) ) {
+                                        $postarr['tax_input'][ $taxonomy ] = $terms;
+                                }
+
+                                if ( empty( $postarr['tax_input'][ $taxonomy ] ) ) {
+                                        $default_term_id = get_option( 'default_taxonomy_' . $taxonomy );
+                                        if ( ! empty( $default_term_id ) ) {
+                                                $postarr['tax_input'][ $taxonomy ] = array( (int) $default_term_id );
+                                        }
+                                }
                         }
                 }

trunk/src/wp-includes/taxonomy.php

@@ -507 +507 @@
         $taxonomy_object->remove_hooks();
 
+        // Remove custom taxonomy default term option.
+        if ( ! empty( $taxonomy_object->default_term ) ) {
+                delete_option( 'default_taxonomy_' . $taxonomy_object->name );
+        }
+
         // Remove the taxonomy.
         unset( $wp_taxonomies[ $taxonomy ] );
@@ -1825 +1830 @@
         }
 
+        // Don't delete the default custom taxonomy term.
+        $taxonomy_object = get_taxonomy( $taxonomy );
+        if ( ! empty( $taxonomy_object->default_term ) ) {
+                $defaults['default'] = (int) get_option( 'default_taxonomy_' . $taxonomy );
+                if ( $defaults['default'] === $term ) {
+                        return 0;
+                }
+        }
+
         $args = wp_parse_args( $args, $defaults );
 
@@ -2513 +2527 @@
         }
 
-        // Add default term.
-        $taxonomy_obj = get_taxonomy( $taxonomy );
-
-        // Default term for this taxonomy.
-        $default_term_id = get_option( 'default_taxonomy_' . $taxonomy );
-        if ( empty( $terms ) && ! empty( $taxonomy_obj->default_term ) && ! empty( $default_term_id ) ) {
-                $terms[] = (int) $default_term_id;
-        }
-
         if ( ! $append ) {
                 $old_tt_ids = wp_get_object_terms(

trunk/tests/phpunit/tests/taxonomy.php

@@ -1000 +1000 @@
                 );
 
+                // Test default category.
                 $term = wp_get_post_terms( $post_id, $tax );
                 $this->assertSame( get_option( 'default_taxonomy_' . $tax ), $term[0]->term_id );
+
+                // Test default term deletion.
+                $this->assertSame( wp_delete_term( $term[0]->term_id, $tax ), 0 );
 
                 // Add custom post type.
@@ -1018 +1022 @@
                 $term    = wp_get_post_terms( $post_id, $tax );
                 $this->assertSame( get_option( 'default_taxonomy_' . $tax ), $term[0]->term_id );
+
+                // wp_set_object_terms shouldn't assign default category.
+                wp_set_object_terms( $post_id, array(), $tax );
+                $term = wp_get_post_terms( $post_id, $tax );
+                $this->assertSame( array(), $term );
+
+                unregister_taxonomy( $tax );
+                $this->assertSame( get_option( 'default_taxonomy_' . $tax ), false );
         }
 }